From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jim Fehlig <jfehlig@novell.com>
Subject: Re: [PATCH] fix 3.3-testing c/s 18434
Date: Fri, 10 Oct 2008 13:09:34 -0600
Message-ID: <48EFA86E.30806@novell.com>
References: <C514C7AA.1E0A7%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="------------020007060707050603040308"
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C514C7AA.1E0A7%keir.fraser@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

This is a multi-part message in MIME format.
--------------020007060707050603040308
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Keir Fraser wrote:
> On 9/10/08 23:02, "Jim Fehlig" <jfehlig@novell.com> wrote:
>
>   
>> Missed that, sorry.
>>
>> I've also found that this c/s causes /local/domain/0/backend/{vkbd, vfb,
>> console} paths to leak :(.  Patch attached.
>>     
>
> A major point of the patch was to stop reading the backend link from the
> frontend directory.

Ah, right.  I should have looked at the patch more closely :-/

>  Is the problem that /vm/... is getting deleted too
> early? Could we delay it?
>   

Turns out that we were just constructing the path incorrectly.  Patch
attached.

Thanks,
Jim


    Signed-off-by: Jim Fehlig <jfehlig@novell.com>


--------------020007060707050603040308
Content-Type: text/x-patch;
 name="xenstore-path.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="xenstore-path.patch"

diff -r 39f6f421eac1 tools/python/xen/xend/server/DevController.py
--- a/tools/python/xen/xend/server/DevController.py	Fri Oct 10 10:15:58 2008 +0100
+++ b/tools/python/xen/xend/server/DevController.py	Fri Oct 10 13:04:54 2008 -0600
@@ -257,7 +257,7 @@ class DevController:
 
         if force:
             frontpath = self.frontendPath(dev)
-            backpath = self.readVm(devid, "backend")
+            backpath = self.readVm(dev, "backend")
             if backpath:
                 xstransact.Remove(backpath)
             xstransact.Remove(frontpath)

--------------020007060707050603040308
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--------------020007060707050603040308--