All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tobias Brunner <tobias.brunner@strongswan.org>
To: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: [PATCH net-next-2.6] af_key: fix SADB_X_SPDDELETE response
Date: Fri, 10 Oct 2008 22:16:48 +0200	[thread overview]
Message-ID: <48EFB830.6030006@strongswan.org> (raw)

When deleting an SPD entry using SADB_X_SPDDELETE, c.data.byid is not 
initialized to zero in pfkey_spddelete(). Thus, key_notify_policy() 
responds with a PF_KEY message of type SADB_X_SPDDELETE2 instead of 
SADB_X_SPDDELETE.

Signed-off-by: Tobias Brunner <tobias.brunner@strongswan.org>
---

diff --git a/net/key/af_key.c b/net/key/af_key.c
index 362fe31..e55e044 100644
--- a/net/key/af_key.c
+++ b/net/key/af_key.c
@@ -2341,6 +2341,7 @@ static int pfkey_spddelete(struct sock *sk, struct sk_buff *skb, struct sadb_msg
 
 	c.seq = hdr->sadb_msg_seq;
 	c.pid = hdr->sadb_msg_pid;
+	c.data.byid = 0;
 	c.event = XFRM_MSG_DELPOLICY;
 	km_policy_notify(xp, pol->sadb_x_policy_dir-1, &c);
 


             reply	other threads:[~2008-10-10 20:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-10 20:16 Tobias Brunner [this message]
2008-10-10 21:07 ` [PATCH net-next-2.6] af_key: fix SADB_X_SPDDELETE response David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48EFB830.6030006@strongswan.org \
    --to=tobias.brunner@strongswan.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.