From: "H. Peter Anvin" <hpa@zytor.com>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [git pull] x86 updates for v2.6.28, phase #1
Date: Fri, 10 Oct 2008 13:43:17 -0700 [thread overview]
Message-ID: <48EFBE65.60505@zytor.com> (raw)
In-Reply-To: <19f34abd0810101339x66afc6d3mb6efa1a52e186816@mail.gmail.com>
Vegard Nossum wrote:
>
> Note: If you don't want the double underscores anywhere, this patch is
> not enough.
>
> For example:
>
>> -#endif /* ASM_X86__MACH_DEFAULT__MACH_TIMER_H */
>> +#endif /* _ASM_X86_MACH_DEFAULT__MACH_TIMER_H */
>
> There are also a few non-trivial changes, which could break with a
> naïve sed script. So I suggest to simply revert it, it's a lot safer
> than trying to patch it up in the last minute.
>
> I'm obviously also sorry for causing this problem in the first place... *blush*
>
Double underscores aren't the problem per se, the problem is having
changes _ASM_X86_ to ASM_X86__ and therefore violating the namespace.
That being said, I don't personally like the double underscores.
-hpa
next prev parent reply other threads:[~2008-10-10 20:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 23:47 [git pull] x86 updates for v2.6.28, phase #1 Ingo Molnar
2008-10-10 15:15 ` Linus Torvalds
2008-10-10 15:26 ` Ingo Molnar
2008-10-10 15:58 ` Ingo Molnar
2008-10-10 20:39 ` Vegard Nossum
2008-10-10 20:43 ` H. Peter Anvin [this message]
2008-10-10 21:07 ` Linus Torvalds
2008-10-10 21:21 ` H. Peter Anvin
2008-10-10 21:37 ` malc
2008-10-10 20:47 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48EFBE65.60505@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.