[Qemu-devel] Re: [5465] hw/apic.c: use __builtin funtions instead of assembly code

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 1182 bytes --]

Aurelien Jarno wrote:
> Revision: 5465
>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5465
> Author:   aurel32
> Date:     2008-10-12 00:53:17 +0000 (Sun, 12 Oct 2008)
> 
> Log Message:
> -----------
> hw/apic.c: use __builtin funtions instead of assembly code
> 
> Suggested by malc.
> 
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> 
> Modified Paths:
> --------------
>     trunk/hw/apic.c
> 
> Modified: trunk/hw/apic.c
> ===================================================================
> --- trunk/hw/apic.c	2008-10-12 00:53:08 UTC (rev 5464)
> +++ trunk/hw/apic.c	2008-10-12 00:53:17 UTC (rev 5465)
> @@ -104,15 +104,14 @@
>  static void apic_set_irq(APICState *s, int vector_num, int trigger_mode);
>  static void apic_update_irq(APICState *s);
>  
> -/* Find first bit starting from msb. Return 0 if value = 0 */
> +/* Find first bit starting from msb */
>  static int fls_bit(uint32_t value)
>  {
> +#if defined(__GNUC__)
> +    return 31 - __builtin_clz(value);

That as well as most (if not all) of the __builtin_* changes are gcc3.4+
stuff. Thus gcc3.3 builds are unfortunately broken now.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]