From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [RFC] Disk integrity in QEMU
Date: Sun, 12 Oct 2008 13:00:48 -0500
Message-ID: <48F23B50.6080402@codemonkey.ws>
References: <48EE38B9.2050106@codemonkey.ws> <48EF1D55.7060307@redhat.com>	<48F0E83E.2000907@redhat.com> <48F10DFD.40505@codemonkey.ws>	<20081012004401.GA9763@acer.localdomain>	<48F1CF9E.9030500@redhat.com> <48F20BBC.1040708@il.qumranet.com> <20081012153546.GD18814@shareable.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Chris Wright <chrisw@redhat.com>,
	Mark McLoughlin <markmc@redhat.com>,
	Ryan Harper <ryanh@us.ibm.com>,
	kvm-devel <kvm@vger.kernel.org>,
	Laurent Vivier <Laurent.Vivier@bull.net>
To: qemu-devel@nongnu.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from an-out-0708.google.com ([209.85.132.243]:44201 "EHLO
	an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754603AbYJLSAz (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 12 Oct 2008 14:00:55 -0400
Received: by an-out-0708.google.com with SMTP id d40so111797and.103
        for <kvm@vger.kernel.org>; Sun, 12 Oct 2008 11:00:52 -0700 (PDT)
In-Reply-To: <20081012153546.GD18814@shareable.org>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Jamie Lokier wrote:
> Dor Laor wrote:
>   
>> Actually this is what happens on mainline qemu with cache=off.
>>     
>
> Have I understood right that cache=off on a qcow2 image only uses
> O_DIRECT for the leaf image, and the chain of base images don't use
> O_DIRECT?
>   

Yeah, that's a bug IMHO and in my patch to add O_DSYNC, I fix that.  I 
think an argument for O_DIRECT in a leaf and wb in the leaf is seriously 
flawed...

Regards,

Anthony Liguori

> Sometimes on a memory constrained host, where the (collective) guest
> memory is nearly as big as the host memory, I'm not sure this is what
> I want.
>
> -- Jamie
>
>
>