From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: [PATCH] x86: propagate return value of alloc_l1_table() Date: Mon, 13 Oct 2008 11:37:06 +0100 Message-ID: <48F340F2.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org A blatant mistake of mine resulted in the return value of alloc_l1_table = to be ignored with the preemptable page table update changes. Signed-off-by: Jan Beulich Index: 2008-09-19/xen/arch/x86/mm.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- 2008-09-19.orig/xen/arch/x86/mm.c 2008-09-19 14:00:01.000000000 = +0200 +++ 2008-09-19/xen/arch/x86/mm.c 2008-10-13 12:07:13.000000000 = +0200 @@ -1883,8 +1883,7 @@ static int alloc_page_type(struct page_i switch ( type & PGT_type_mask ) { case PGT_l1_page_table: - alloc_l1_table(page); - rc =3D 0; + rc =3D alloc_l1_table(page); break; case PGT_l2_page_table: rc =3D alloc_l2_table(page, type, preemptible);