All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: GIT head no longer boots on x86-64
Date: Mon, 13 Oct 2008 16:50:51 +0200	[thread overview]
Message-ID: <48F3604B.8050105@gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0810130740360.3288@nehalem.linux-foundation.org>

On 10/13/2008 04:45 PM, Linus Torvalds wrote:
> 
> On Mon, 13 Oct 2008, Jiri Slaby wrote:
>> +	sprint_symbol(buf, (unsigned long)__builtin_return_address(0));
>> +	if (!is_vmalloc_addr(vmalloc_addr) && !is_module_address(addr))
>> +		printk("BUG? %s (from %s): %p\n", __func__, buf, vmalloc_addr);
> 
> Just use
> 
> 	printk("BUG? %s (from %pS): %p\n",
> 		__func__,
> 		__builtin_return_address(0),
> 		vmalloc_addr);
> 
> and don't ever sprint_symbol() any more. 

Ok, thanks, I knew about it, but didn't remember it while I was hacking that
debug patch.

      reply	other threads:[~2008-10-13 14:51 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-13  9:23 GIT head no longer boots on x86-64 Alan Cox
2008-10-13 10:13 ` Jiri Slaby
2008-10-13 10:20   ` Alan Cox
2008-10-13 10:56     ` Jiri Slaby
2008-10-13 13:35       ` Alan Cox
2008-10-13 15:03         ` Linus Torvalds
2008-10-13 15:11           ` Jiri Slaby
2008-10-13 15:11             ` Jiri Slaby
2008-10-13 15:47             ` Alan Cox
2008-10-13 15:47               ` Alan Cox
2008-10-15 11:51               ` Ingo Molnar
2008-10-15 11:51                 ` Ingo Molnar
2008-10-15 13:19                 ` Jiri Slaby
2008-10-15 13:19                   ` Jiri Slaby
2008-10-15 15:06                 ` Linus Torvalds
2008-10-15 15:06                   ` Linus Torvalds
2008-10-15 15:33                   ` Jiri Slaby
2008-10-15 15:33                     ` Jiri Slaby
2008-10-15 16:01                     ` Linus Torvalds
2008-10-15 16:01                       ` Linus Torvalds
2008-10-15 20:31                     ` Arjan van de Ven
2008-10-15 20:31                       ` Arjan van de Ven
2008-10-15 15:35                   ` Linus Torvalds
2008-10-15 15:35                     ` Linus Torvalds
2008-10-16 10:31                     ` H. Peter Anvin
2008-10-16 10:31                       ` H. Peter Anvin
2008-10-13 14:45       ` Linus Torvalds
2008-10-13 14:50         ` Jiri Slaby [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48F3604B.8050105@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.