All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yosuke Iwamatsu <y-iwamatsu@ab.jp.nec.com>
To: haicheng.li@intel.com, Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: ioemu: Re-enable guest boot with blktap devices (Weekly VMX status report. Xen: #18577 & Xen0: #696)
Date: Tue, 14 Oct 2008 13:04:29 +0900	[thread overview]
Message-ID: <48F41A4D.1020608@ab.jp.nec.com> (raw)
In-Reply-To: <76780B19A496DC4B80439008DAD7076C01ACDF710F@PDSMSX501.ccr.corp.intel.com>

Li, Haicheng wrote:
> Our testing was blocke by bug #1367; and totally 2 new issues were found this week,
> 
> New Bugs:
> =====================================================================
> 1. [Qcow]Guest cannot boot up with Qcow image
> http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=1367

Bug #1367 looks caused by the xenstore path checking code recently added
to ioemu-remote. I saw the same problem and found that the code didn't
consider the case blktap devices were attached to the guest. The patch
below should avoid the problem.

Signed-off-by: Yosuke Iwamatsu <y-iwamatsu@ab.jp.nec.com>

diff --git a/xenstore.c b/xenstore.c
index f5aa8a7..39ff8a6 100644
--- a/xenstore.c
+++ b/xenstore.c
@@ -158,6 +158,7 @@ static void xenstore_get_backend_path(char 
**backend, const char *devtype,
      char *frontend_path=0;
      char *backend_dompath=0;
      char *expected_backend=0;
+    char *expected_devtype=0;
      char *frontend_backend_path=0;
      char *backend_frontend_path=0;
      char *frontend_doublecheck=0;
@@ -191,11 +192,18 @@ static void xenstore_get_backend_path(char 
**backend, const char *devtype,
      backend_dompath = xs_get_domain_path(xsh, domid_backend);
      if (!backend_dompath) goto out;

+    if (pasprintf(&expected_devtype, "%s", devtype) == -1) goto out;
+
+ again:
      if (pasprintf(&expected_backend, "%s/backend/%s/%lu/%s",
-                  backend_dompath, devtype, frontend_domid, inst_danger)
+                  backend_dompath, expected_devtype, frontend_domid, 
inst_danger)
          == -1) goto out;

      if (strcmp(bpath, expected_backend)) {
+        if (!strcmp(expected_devtype, "vbd")) {
+            pasprintf(&expected_devtype, "tap");
+            goto again;
+        }
          fprintf(stderr, "frontend `%s' expected backend `%s' got `%s',"
                  " ignoring\n", frontend_path, expected_backend, bpath);
          errno = EINVAL;
@@ -223,6 +231,7 @@ static void xenstore_get_backend_path(char 
**backend, const char *devtype,
      free(frontend_path);
      free(backend_dompath);
      free(expected_backend);
+    free(expected_devtype);
      free(frontend_backend_path);
      free(backend_frontend_path);
      free(frontend_doublecheck);

  reply	other threads:[~2008-10-14  4:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-11  7:05 Weekly VMX status report. Xen: #18577 & Xen0: #696 Li, Haicheng
2008-10-14  4:04 ` Yosuke Iwamatsu [this message]
2008-10-14  7:13   ` ioemu: Re-enable guest boot with blktap devices ( Weekly VMX status report. Xen: #18577 & Xen0: #696) Keir Fraser
2008-10-14 10:49   ` Ian Jackson
2008-10-14 23:57     ` Yosuke Iwamatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48F41A4D.1020608@ab.jp.nec.com \
    --to=y-iwamatsu@ab.jp.nec.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=haicheng.li@intel.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.