[Qemu-devel] Re: [PATCH 4/7] give noaccel a name

[Avi Kivity <avi@redhat.com>]

Glauber Costa wrote:
> otherwise, string comparisons to check for the current accelerator
> may break.
>
> Signed-off-by: Glauber Costa <glommer@redhat.com>
> ---
>  accel.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/accel.c b/accel.c
> index f9618b2..bf3cb73 100644
> --- a/accel.c
> +++ b/accel.c
> @@ -21,7 +21,7 @@ CPUState *noaccel_get_env(void)
>  
>  /* Accelerator wrapper for the no-accel (raw qemu) case */
>  QEMUAccel noaccel = {
> -    .name = NULL,
> +    .name = "noaccel",
>      .cpu_interrupt = accel_nop,
>      .init_env = accel_nop,
>      .get_env = noaccel_get_env,
>   

Maybe "none" or "tcg" or "emulation"?

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.