All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	Krzysztof Oledzki <ole@ans.pl>,
	netdev@vger.kernel.org
Subject: Re: Error: an inet prefix is expected rather than "0/0".
Date: Tue, 14 Oct 2008 23:52:45 +0200	[thread overview]
Message-ID: <48F514AD.3010109@trash.net> (raw)
In-Reply-To: <20081014104621.3c2ce4d3@extreme>

Stephen Hemminger wrote:
> There is no easy solution, I'll will have to go back rewrite this
> code, and will document the result. I expect the result will displease
> someone, but given the original code that is just going to happen.
> 
> Busted cases:
>                            correct           incorrect
> Original code: 127.2   =>  127.0.0.2         127.2.0.0
> inet_pton:     10.0    =>  10.0.0.0          fails invalid
> inet_aton:     10      =>  10.0.0.0          0.0.0.10
> 
> The problem was Alexey (or Jamal) invented their own abbreviation format
> and did not follow unix standard conventions.

We fixed the same problem in iptables a few years ago, maybe you could
reuse some of that code. Some quick testing shows that it parses all
addresses according to your table:

# iptables -I OUTPUT -d 127.2
# iptables -I OUTPUT -d 10.0
# iptables -I OUTPUT -d 10
# iptables -vxnL OUTPUT
Chain OUTPUT (policy ACCEPT 0 packets, 0 bytes)
     pkts      bytes target     prot opt in     out     source 
      destination
        0        0            all  --  *      *       0.0.0.0/0 
    10.0.0.0
        0        0            all  --  *      *       0.0.0.0/0 
    10.0.0.0
        0        0            all  --  *      *       0.0.0.0/0 
    127.2.0.0

You can find the code in "xtables.c", function numeric_to_ipaddr().

  parent reply	other threads:[~2008-10-14 21:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-08 21:05 Error: an inet prefix is expected rather than "0/0" Krzysztof Oledzki
2008-10-08 21:32 ` Krzysztof Oledzki
2008-10-14 14:01   ` Herbert Xu
2008-10-14 17:46     ` Stephen Hemminger
2008-10-14 19:15       ` Krzysztof Oledzki
2008-10-14 19:18         ` Stephen Hemminger
2008-10-14 19:38           ` Ben Hutchings
2008-10-14 21:52       ` Patrick McHardy [this message]
2008-10-14 21:54         ` Patrick McHardy
2008-10-15  1:46       ` Herbert Xu
2008-10-15 15:35         ` Krzysztof Halasa
2008-10-15 16:07           ` Ben Hutchings
2008-10-15 18:52             ` Krzysztof Halasa
2008-10-27 17:39               ` Stephen Hemminger
2008-10-28  1:51                 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48F514AD.3010109@trash.net \
    --to=kaber@trash.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=ole@ans.pl \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.