Re: [PATCH 1/3] ide: mask interrupt in ide_config_drive_speed()

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello, I wrote:

> Apparently, there is no sense in unmasking IRQ on the controller when you call
> disable_irq_nosync() before doing this, set the nIEN bit afterwards, and then
> unmask IRQ again after the command completion, hence 1 passed to SELECT_MASK()
>   

   s/1/0/, of course...

> before issuing the command in ide_config_drive_speed() is probably just a typo.
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
>  drivers/ide/ide-iops.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6/drivers/ide/ide-iops.c
> ===================================================================
> --- linux-2.6.orig/drivers/ide/ide-iops.c
> +++ linux-2.6/drivers/ide/ide-iops.c
> @@ -840,7 +840,7 @@ int ide_config_drive_speed(ide_drive_t *
>  	 
>  	udelay(1);
>  	SELECT_DRIVE(drive);
> -	SELECT_MASK(drive, 0);
> +	SELECT_MASK(drive, 1);
>  	udelay(1);
>  	tp_ops->set_irq(hwif, 0);
>   

MBR, Sergei