From: Ric Wheeler <rwheeler@redhat.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org, Eric Sandeen <sandeen@redhat.com>
Subject: Re: jbd/jbd2 performance improvements
Date: Wed, 15 Oct 2008 13:29:55 -0400 [thread overview]
Message-ID: <48F62893.9060606@redhat.com> (raw)
In-Reply-To: <E1KnCO6-0001qG-SV@closure.thunk.org>
Theodore Ts'o wrote:
> As I mentioned on the ext4 call yesterday, there was an interesting
> thread on LKML that wasn't cc'ed onto the linux-ext4 mailing list. So
> in case folks missed it, it might be worth taking a look at this mail
> thread:
>
> [PATCH] Give kjournald a IOPRIO_CLASS_RT io priority
>
> http://lkml.org/lkml/2008/10/1/405
>
> The main issue that got discussed was the age-old "entaglement" problem.
> The jbd/jbd2 layer is supposed to avoid this by not blocking the
> "current" transaction why the blocks from the previous "committing"
> transaction are still being written out to disk. Apparently this was
> broken sometime in the 2.5 time-frame:
>
> http://lkml.org/lkml/2008/10/2/41
> http://lkml.org/lkml/2008/10/2/322
>
> Later in the thread, a major contention point in do_get_write_access()
> was identified as the problem:
>
> http://lkml.org/lkml/2008/10/3/7
>
> ... and then andrew produced the following "hacky" fix:
>
> http://lkml.org/lkml/2008/10/3/22
>
> If someone has time to runs some benchmarks to see how this improves
> things, especially on a workload that has plenty of "engtanglements",
> that would be great. (I bet Ric's fs_mark run should do a good job;
> fsyncs to creates lots of commits and the need to modify blocks that had
> been modified in the previous tansactions.)
>
> If we can get some quick testing done, and it shows really good results,
> this could be something that could try fast-tracking into the 2.6.28
> merge window.
>
> - Ted
>
We are going to try and poke at this - do you suspect a single or
multi-threaded test would work best?
Ric
next prev parent reply other threads:[~2008-10-15 17:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-07 13:14 jbd/jbd2 performance improvements Theodore Ts'o
2008-10-15 17:29 ` Ric Wheeler [this message]
2008-10-16 6:04 ` Solofo.Ramangalahy
2008-10-16 12:06 ` Ric Wheeler
2008-10-16 12:39 ` Eric Sandeen
2008-10-23 10:42 ` Solofo.Ramangalahy
2008-10-23 12:00 ` Ric Wheeler
2008-10-23 12:22 ` Solofo.Ramangalahy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F62893.9060606@redhat.com \
--to=rwheeler@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.