All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave <kilroyd@googlemail.com>
To: Andrey Borzenkov <arvidjaar@mail.ru>
Cc: orinoco-devel@lists.sourceforge.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] orinoco: reload firmware on resume
Date: Wed, 15 Oct 2008 20:31:26 +0100	[thread overview]
Message-ID: <48F6450E.7040809@gmail.com> (raw)
In-Reply-To: <200810121636.34373.arvidjaar@mail.ru>

Andrey Borzenkov wrote:
> On Saturday 11 October 2008, Dave wrote:
>>> -	int err;
>>> +	int err = 0;
> 
> Fixed version attached.

Acked-by: David Kilroy <kilroyd@googlemail.com>


Note that if the firmware download fails the card won't work because we no longer  allocate a fid. However even if we were to allocate a fid the driver flags would be inconsistent with the firmware capabilities, and the driver would just encounter a bunch of errors.

We should probably think about how we can fall back to the inbuilt firmware after a failed firmware download - but this can be done separately.


Regards,

Dave.

  reply	other threads:[~2008-10-15 19:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-11 14:16 [PATCH 1/2] orinoco: reload firmware on resume Andrey Borzenkov
2008-10-11 14:21 ` [PATCH 2/2] orinoco: cache downloadable firmware image in memory for use during resume Andrey Borzenkov
2008-10-11 17:59   ` Dave
2008-10-12 17:42     ` Andrey Borzenkov
2008-10-11 17:42 ` [PATCH 1/2] orinoco: reload firmware on resume Dave
2008-10-11 18:34   ` Andrey Borzenkov
2008-10-12 12:36   ` Andrey Borzenkov
2008-10-15 19:31     ` Dave [this message]
2008-10-22 18:26       ` John W. Linville
  -- strict thread matches above, loose matches on Subject: below --
2008-10-26  8:21 Andrey Borzenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48F6450E.7040809@gmail.com \
    --to=kilroyd@googlemail.com \
    --cc=arvidjaar@mail.ru \
    --cc=linux-wireless@vger.kernel.org \
    --cc=orinoco-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.