All of lore.kernel.org
 help / color / mirror / Atom feed
From: richardretanubun <richardretanubun@ruggedcom.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [83xx] [RFC] Widening the scope of u-boot/cpu/mpc83xx/cpu.c : upmconfig
Date: Wed, 15 Oct 2008 17:35:39 -0400	[thread overview]
Message-ID: <48F6622B.8050109@ruggedcom.com> (raw)

Hi Kim,

I recently tried calling the u-boot/cpu/mpc83xx/cpu.c : upmconfig function 
to configure one of my UPMs to work as a Compact flash controller.

When I tried the compile I am getting the error from the #else of this code

void upmconfig (uint upm, uint *table, uint size)
{
#if defined(CONFIG_MPC834X)
[snip]
#else
    printf("Error: %s() not defined for this configuration.\n", __FUNCTION__);
    hang();
#endif
}

Two questions:
1. Can the CONFIG_MPC834X limitation be relaxed? (I am using an MPC8360E), If so, what should it be? CONFIG_83XX?
2. Can the #else action be changed from a printf to a #error? Something like this, maybe?

#else
    #error upmconfig function not defined for this configuration.
#endif

This alerts earlier during compile and not a hang during run time.

Please let me know what you think and I can submit a patch for it.

Thanks for your time

Regards,
- Richard Retanubun

             reply	other threads:[~2008-10-15 21:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-15 21:35 richardretanubun [this message]
2008-10-15 22:47 ` [U-Boot] [83xx] [RFC] Widening the scope of u-boot/cpu/mpc83xx/cpu.c : upmconfig Kim Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48F6622B.8050109@ruggedcom.com \
    --to=richardretanubun@ruggedcom.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.