From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [v2] Shared guest irq support Date: Thu, 16 Oct 2008 10:21:38 +0200 Message-ID: <48F6F992.3020203@redhat.com> References: <42DFA526FC41B1429CE7279EF83C6BDC01AFB25A@pdsmsx415.ccr.corp.intel.com> <200810151233.39384.amit.shah@redhat.com> <200810151511.18028.sheng@linux.intel.com> <200810151533.54549.amit.shah@redhat.com> <42DFA526FC41B1429CE7279EF83C6BDC01B47E5C@pdsmsx415.ccr.corp.intel.com> <42DFA526FC41B1429CE7279EF83C6BDC01B47EA3@pdsmsx415.ccr.corp.intel.com> <42DFA526FC41B1429CE7279EF83C6BDC01B47EAC@pdsmsx415.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Amit Shah , Sheng Yang , kvm@vger.kernel.org To: "Zhang, Xiantao" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:56282 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752942AbYJPIVn (ORCPT ); Thu, 16 Oct 2008 04:21:43 -0400 In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC01B47EAC@pdsmsx415.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Zhang, Xiantao wrote: > Forget to modify the from item generated automatically by git. Modified > to Sheng Yang :) > Xiantao > > From c0d1ad6327c01ba0584922022bef48c971bbf18a Mon Sep 17 00:00:00 2001 > From: Sheng Yang > Date: Wed, 15 Oct 2008 20:15:06 +0800 > Subject: [PATCH] KVM: Fix guest shared interrupt with in-kernel irqchip > > Every call of kvm_set_irq() should offer an irq_source_id, which is > allocated by kvm_request_irq_source_id(). Based on irq_source_id, we > identify the irq source and implement logical OR for shared level > interrupts. > > The allocated irq_source_id can be freed by kvm_free_irq_source_id(). > > Currently, we support at most sizeof(unsigned long) different irq > sources. > > > > +#define KVM_USERSPACE_IRQ_SOURCE_ID 1 << 0 > + > This is dangerous, if used in an expression together with a higher precedence operator. I fixed it and applied. Thanks to all involved. -- error compiling committee.c: too many arguments to function