From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [v2] Shared guest irq support
Date: Thu, 16 Oct 2008 10:47:23 +0200
Message-ID: <48F6FF9B.9040707@redhat.com>
References: <42DFA526FC41B1429CE7279EF83C6BDC01AFB25A@pdsmsx415.ccr.corp.intel.com> <42DFA526FC41B1429CE7279EF83C6BDC01B47EAC@pdsmsx415.ccr.corp.intel.com> <48F6F992.3020203@redhat.com> <200810161401.56729.amit.shah@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "Zhang, Xiantao" <xiantao.zhang@intel.com>,
	Sheng Yang <sheng@linux.intel.com>, kvm@vger.kernel.org
To: Amit Shah <amit.shah@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:52278 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752269AbYJPIr2 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 16 Oct 2008 04:47:28 -0400
In-Reply-To: <200810161401.56729.amit.shah@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Amit Shah wrote:
>>>
>>>
>>> +#define KVM_USERSPACE_IRQ_SOURCE_ID	1 << 0
>>> +
>>>       
>> This is dangerous, if used in an expression together with a higher
>> precedence operator.  I fixed it and applied.  Thanks to all involved.
>>     
>
> Thanks; however, Sheng suggested we should use set_bit to set the 
> corresponding bit since we're operating on bitfields in a bitmap.
>   

We are actually using set_bit, so the value should be zero.

-- 
error compiling committee.c: too many arguments to function