From: Jeff Garzik <jeff@garzik.org>
To: Roland Dreier <rdreier@cisco.com>
Cc: scofeldm@cisco.com, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] enic: Fix Kconfig headline description
Date: Thu, 16 Oct 2008 05:30:42 -0400 [thread overview]
Message-ID: <48F709C2.6000303@garzik.org> (raw)
In-Reply-To: <adaej2kp701.fsf@cisco.com>
Roland Dreier wrote:
> From: Scott Feldman <scofeldm@cisco.com>
>
> I don't think the enic driver has anything to do with Mark Everett
> (http://en.wikipedia.org/wiki/A_Man_Called_E). Fix the Kconfig
> description.
>
> Signed-off-by: Roland Dreier <rolandd@cisco.com>
> ---
> And this is the other half of
> https://kerneltrap.org/mailarchive/linux-netdev/2008/9/20/3350614/thread
> that seems to have gotten dropped. Please apply.
>
> drivers/net/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index e9d5294..1d8af33 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2400,7 +2400,7 @@ config EHEA
> will be called ehea.
>
> config ENIC
> - tristate "E, the Cisco 10G Ethernet NIC"
> + tristate "Cisco 10G Ethernet NIC support"
> depends on PCI && INET
Sheesh, Cisco just does not have any sense of humor :)
As I explained to Scott (in private email, unfortunately, IIRC), I did
that so that it would fit in the list alphabetized -- Scott placed it in
the section with the E's, not the C's.
Furthermore, "Cisco 10G ethernet nic" is a vague description if Cisco
ever plans to sell another ethernet product. Will the next one be
"Cisco 10G Ethernet NIC, the sequel"? :)
If you insist on such an incredibly boring description, at least put it
into the section with the 'C' not the 'E'.
Jeff
next prev parent reply other threads:[~2008-10-16 9:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 20:36 [PATCH 2/2] enic: Fix Kconfig headline description Roland Dreier
2008-10-14 1:53 ` David Miller
2008-10-16 9:30 ` Jeff Garzik [this message]
2008-10-16 22:43 ` Roland Dreier
2008-10-27 18:43 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F709C2.6000303@garzik.org \
--to=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=scofeldm@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.