All of lore.kernel.org
 help / color / mirror / Atom feed
From: Uri Lublin <uri@il.qumranet.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Avi Kivity <avi@redhat.com>, Uri Lublin <uril@qumranet.com>,
	kvm@vger.kernel.org
Subject: Re: [PATCH] qemu: qemu_fopen_fd: differentiate between reader and writer user
Date: Thu, 16 Oct 2008 12:52:25 +0200	[thread overview]
Message-ID: <48F71CE9.6090902@il.qumranet.com> (raw)
In-Reply-To: <48F6BFA1.9070608@codemonkey.ws>

Anthony Liguori wrote:
> Uri Lublin wrote:
>> Anthony Liguori wrote:
> 
> I have already cut your text, but I don't understand the comment about 
> not being "full duplex".  Is there a reason why migration needs to be 
> bidirectional?  I don't think there's a fundamental reason it needs to 
> be and I think there are some advantages to it being unidirectional.
> 

Avi was concerned that my patch makes QEMUFile uni-directional, so I assumed you 
are trying to "fix" that too. Unidirectional-only usage of QEMUFile was working. 
The problem was that the fd implementation registered both get_buffer and 
put_buffer. If you never register both non-NULL get_buffer and put_buffer 
(unidirectional), then you do not need the is_write field.

Adding the error checking is valuable.

Thanks,
Uri.

  parent reply	other threads:[~2008-10-16 10:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-12 16:30 [PATCH] qemu: qemu_fopen_fd: differentiate between reader and writer user Uri Lublin
2008-10-12 16:55 ` Avi Kivity
2008-10-12 18:09   ` Anthony Liguori
2008-10-12 18:17     ` Avi Kivity
2008-10-12 22:18       ` Anthony Liguori
2008-10-13  3:03         ` Anthony Liguori
2008-10-16  1:36           ` Uri Lublin
2008-10-16  4:14             ` Anthony Liguori
2008-10-16  8:13               ` Avi Kivity
2008-10-16 12:54                 ` Anthony Liguori
2008-10-16 14:23                   ` Uri Lublin
2008-10-16 14:32                     ` Avi Kivity
2008-10-16 14:49                       ` Uri Lublin
2008-10-17  2:47                         ` Anthony Liguori
2008-10-19 13:46                           ` Uri Lublin
2008-10-19 22:00                             ` Anthony Liguori
2008-10-22 16:23                               ` Uri Lublin
2008-10-16 10:52               ` Uri Lublin [this message]
2008-10-16  0:13   ` Uri Lublin
2008-10-16  4:10     ` Anthony Liguori
2008-10-16  8:16       ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48F71CE9.6090902@il.qumranet.com \
    --to=uri@il.qumranet.com \
    --cc=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=uril@qumranet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.