All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] xt_recent: use proc_create_data()
Date: Thu, 16 Oct 2008 16:08:32 +0200	[thread overview]
Message-ID: <48F74AE0.4030105@trash.net> (raw)
In-Reply-To: <20081016140320.GB17872@x200.localdomain>

Alexey Dobriyan wrote:
> On Thu, Oct 16, 2008 at 03:12:30PM +0200, Patrick McHardy wrote:
>> Alexey Dobriyan wrote:
>>> It's tiny little bit safer because ->data always appears initialized.
>> These don't seem to actually fix anything,
> 
> It does ;-) Initializing ->data after proc_create() when proc entry
> becomes fully visible and accessible is no-no.

Thanks for the explanation, applied.

      reply	other threads:[~2008-10-16 14:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-15  4:13 [PATCH 1/2] xt_recent: use proc_create_data() Alexey Dobriyan
2008-10-16 13:12 ` Patrick McHardy
2008-10-16 14:03   ` Alexey Dobriyan
2008-10-16 14:08     ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48F74AE0.4030105@trash.net \
    --to=kaber@trash.net \
    --cc=adobriyan@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.