All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Chr <chunkeey@web.de>, Johannes Berg <johannes@sipsolutions.net>
Cc: wireless <linux-wireless@vger.kernel.org>
Subject: Warning from mac80211 with p54usb
Date: Thu, 16 Oct 2008 16:40:02 -0700	[thread overview]
Message-ID: <48F7D0D2.6090604@lwfinger.net> (raw)

Christian,

Many thanks for the renaming of the firmware for p54usb. With this change, I can
keep an old version of the firmware (2.5.8.0.arm) named isl3887usb_bare and a
new one (2.13.1.0.arm.1) named isl3887usb in /lib/firmware and run the trees
from Linus and wireless-testing without messing with the firmware.

I have discovered one anomaly that shows up with firmware 2.5.8.0.arm. If the
USB device is unplugged and replugged, mac80211 will log the warning from
net/mac80211/main.c:234 because p54_config() returns an error. The source of the
error is p54_assign_address(), where target_skb is NULL. That happens because
priv->rx_end - last_addr is 32 whereas the value of len is 160 - thus target_skb
never gets set.

I have not seen this problem with firmware 2.13.1.arm.1, nor does it occur if
the driver is removed before the USB device is replugged.

If you have any suggestions regarding debugging, please let me know.

Larry


             reply	other threads:[~2008-10-16 23:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-16 23:40 Larry Finger [this message]
2008-10-17  0:26 ` Warning from mac80211 with p54usb Christian Lamparter
2008-10-18 23:15   ` Larry Finger
2008-10-19 10:19     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48F7D0D2.6090604@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=chunkeey@web.de \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.