All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: David Miller <davem@davemloft.net>
Cc: benh@kernel.crashing.org, torvalds@linux-foundation.org,
	rdreier@cisco.com, Geert.Uytterhoeven@sonycom.com,
	linux-kernel@vger.kernel.org, mingo@elte.hu,
	yhlu.kernel@gmail.com, akpm@linux-foundation.org
Subject: Re: [PATCH] Fix broken debug output reserve_region_with_split()
Date: Thu, 16 Oct 2008 23:51:53 -0700	[thread overview]
Message-ID: <48F83609.4090407@zytor.com> (raw)
In-Reply-To: <20081016.234747.193703936.davem@davemloft.net>

David Miller wrote:
>>>
>> IMNSHO I think you can default to 8 digits for I/O for PCI, since at least last I looked there was no 64-bit address space possible for I/O.
> 
> Resources are representing different things on different platforms.
> 
> On sparc64 it's actually the full 64-bit physical I/O address on the
> system bus being stored in there.  So even IORESOURCE_IO objects have
> 64-bits of relevancy.
> 

And then it should be printed as such on that platform.

> Like I said, printing out the entire thing has helped me find real
> bugs, so printing the whole thing is not without merit.

No argument there.  I was referring only to platforms where the resource 
contains a PCI I/O address, which is 32 bits long unless limited by 
additional constraints (like x86's 16-bit limit.)

	-hpa

  reply	other threads:[~2008-10-17  6:55 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-14  0:53 [PATCH] Fix broken debug output reserve_region_with_split() Benjamin Herrenschmidt
2008-10-14  1:04 ` H. Peter Anvin
2008-10-14  1:14   ` Yinghai Lu
2008-10-14  1:16     ` H. Peter Anvin
2008-10-14  1:34     ` David Miller
2008-10-14  1:41     ` Benjamin Herrenschmidt
2008-10-14  1:41   ` Benjamin Herrenschmidt
2008-10-14  1:45     ` David Miller
2008-10-14  2:15       ` Benjamin Herrenschmidt
2008-10-14  2:54     ` H. Peter Anvin
2008-10-14  3:47       ` Benjamin Herrenschmidt
2008-10-14  5:38       ` David Miller
2008-10-16  8:30         ` Geert Uytterhoeven
2008-10-16  8:38           ` David Miller
2008-10-16  9:02             ` H. Peter Anvin
2008-10-17  3:02             ` Benjamin Herrenschmidt
2008-10-17  3:06               ` Benjamin Herrenschmidt
2008-10-17  3:13                 ` Roland Dreier
2008-10-17  3:31                   ` Benjamin Herrenschmidt
2008-10-17  3:49                     ` Linus Torvalds
2008-10-17  4:04                       ` David Miller
2008-10-17  4:18                         ` Linus Torvalds
2008-10-17  5:00                           ` Benjamin Herrenschmidt
2008-10-17  5:24                             ` David Miller
2008-10-17  5:12                           ` Benjamin Herrenschmidt
2008-10-17  5:21                             ` Benjamin Herrenschmidt
2008-10-17 10:13                             ` Olivier Galibert
2008-10-17 15:54                             ` Linus Torvalds
2008-10-17 20:30                               ` H. Peter Anvin
2008-10-17 20:54                                 ` Linus Torvalds
2008-10-17 21:03                               ` Benjamin Herrenschmidt
2008-10-17 21:11                                 ` Linus Torvalds
2008-10-17 21:45                                   ` Benjamin Herrenschmidt
2008-10-20  3:37                                     ` Benjamin Herrenschmidt
2008-10-17  5:21                           ` David Miller
2008-10-17  6:36                             ` Benjamin Herrenschmidt
2008-10-17  6:39                               ` H. Peter Anvin
2008-10-17  6:47                                 ` David Miller
2008-10-17  6:51                                   ` H. Peter Anvin [this message]
2008-10-17 15:51                             ` Linus Torvalds
2008-10-17 20:06                               ` David Miller
2008-10-17  4:05                       ` Benjamin Herrenschmidt
2008-10-17  6:36                         ` H. Peter Anvin
2008-10-17  3:39                 ` Yinghai Lu
2008-10-17  3:46                   ` Benjamin Herrenschmidt
2008-10-17  6:38                     ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48F83609.4090407@zytor.com \
    --to=hpa@zytor.com \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rdreier@cisco.com \
    --cc=torvalds@linux-foundation.org \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.