From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhao, Yu" Subject: Re: [PATCH] conditionalize PCI reassign code Date: Fri, 17 Oct 2008 15:27:36 +0800 Message-ID: <48F83E68.7060303@intel.com> References: <48F4BD46.76E4.0078.0@novell.com> <48F7FBE9.6030207@intel.com> <48F85833.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <48F85833.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: "xen-devel@lists.xensource.com" , Keir Fraser List-Id: xen-devel@lists.xenproject.org Jan Beulich wrote: >>>> "Zhao, Yu" 17.10.08 04:43 >>> >> There is build error (c/s 701) with this patch, please take a look. > > This is why I always include > >>> As usual, written and tested on 2.6.27 and made apply to the 2.6.18 >>> tree without further testing. > > I'm making a best effort attempt at getting things in proper state for that > tree, but time-wise can't afford full validation. But I always assumed that > if this appears in the real (not the staging) tree, it at least survived > building in Citrix' trees - is that not correct, Keir? > > As you observed the build error - why don't you provide at least the > error the compiler generated? That might make it possible to provide a > fix quickly. +#ifdef CONFIG_PCI_REASSIGN extern int reassign_resources; extern int is_reassigndev(struct pci_dev *dev); extern void pci_update_bridge(struct pci_dev *dev, int resno); +#else +#define reassign_resources 0 +#define is_reassigndev(dev) 0 +#endif When the CONFIG_PCI_REASSIGN is not set, e.g., a domU kernel, the following line fails to be compiled (drivers/pci/quirks.c): int reassign_resources = 0; > > Jan >