From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Zhao, Yu" <yu.zhao@intel.com>
Subject: Re: [PATCH] conditionalize PCI reassign code
Date: Fri, 17 Oct 2008 15:38:36 +0800
Message-ID: <48F840FC.9030507@intel.com>
References: <C51DFE90.1E466%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C51DFE90.1E466%keir.fraser@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Keir Fraser wrote:
> 
> 
> On 17/10/08 08:27, "Zhao, Yu" <yu.zhao@intel.com> wrote:
> 
>>> As you observed the build error - why don't you provide at least the
>>> error the compiler generated? That might make it possible to provide a
>>> fix quickly.
>> +#ifdef CONFIG_PCI_REASSIGN
>>   extern int reassign_resources;
>>   extern int is_reassigndev(struct pci_dev *dev);
>>   extern void pci_update_bridge(struct pci_dev *dev, int resno);
>> +#else
>> +#define reassign_resources 0
>> +#define is_reassigndev(dev) 0
>> +#endif
>>
>> When the CONFIG_PCI_REASSIGN is not set, e.g., a domU kernel, the
>> following line fails to be compiled (drivers/pci/quirks.c):
>>
>> int reassign_resources = 0;
> 
> Ah, the automated tests only build the -xen config.
> 
>  -- Keir
> 
> 

Actually I happened to get it by misusing a native kernel config ...