Re: udev-test.pl failures

[Alan Jenkins <alan-jenkins@tuffmail.co.uk>]

Kay Sievers wrote:
> On Tue, Sep 16, 2008 at 7:16 PM, Kay Sievers <kay.sievers@vrfy.org> wrote:
>   
>> On Tue, Sep 16, 2008 at 03:09, Alan Jenkins <alan-jenkins@tuffmail.co.uk> wrote:
>>     
>>> commit 8753fadf2a6ecead372e71b8bf9336cf29f9c958
>>>       
>>> Lots of the udev tests fail here.  udev_sysfs.c broke when
>>> util_resolve_sys_link() switched API.
>>>       
>> Ah, sorry, should be fixed now.
>>
>>     
>>> I'll leave this up to you - maybe
>>> your next commit is going to do away with udev_sysfs.c altogether :-).
>>>       
>> It will go away soon, yeah. We should get rid of udev_sysfs.c and
>> "struct udevice".
>>     
>
> Along with a lot of other stuff, udev_sysfs.c is gone. Also the global
> event environment is replaced by a per-device property list. The
> daemon, and everything else uses the libudev code now.
>
> It seems to work fine here, but the code may be a bit rough at the
> moment, until it has seen more testing. But, it should be pretty easy
> now to play around with a threaded version of the daemon.
>
> Thanks,
> Kay
>   

Great.  I don't have so much time now though; I need to concentrate on
project work.

Going back to the original subject line... :-).  I see the tests still
pass, but some of them make suspicious noises now.

TEST 7: label test of max sysfs files
device
'/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda1'
expecting node 'boot_disk1'
libudev: add_rule_key_pair: skip, too many keys of the same type in a
single rule                            
libudev: add_to_rules: invalid rule
'/home/alan/Documents/bootup/src/udev/test/udev-test.rules:1'            
add:         ok
libudev: add_rule_key_pair: skip, too many keys of the same type in a
single rule                            
libudev: add_to_rules: invalid rule
'/home/alan/Documents/bootup/src/udev/test/udev-test.rules:1'            
remove:      ok

TEST 19: Handle stupid backslashed multi lines in config file (and
replace kernel name)
device '/devices/pci0000:00/0000:00:1d.7/usb5/5-2/5-2:1.0/tty/ttyACM0'
expecting node 'modem'
libudev: add_to_rules: invalid rule
'/home/alan/Documents/bootup/src/udev/test/udev-test.rules:4'
add:         ok
libudev: add_to_rules: invalid rule
'/home/alan/Documents/bootup/src/udev/test/udev-test.rules:4'
remove:      ok

TEST 118: ENV{} test (assign2)
device
'/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda1'
expecting node 'part'
libudev: add_to_rules: invalid rule
'/home/alan/Documents/bootup/src/udev/test/udev-test.rules:1'      
add:        
ok                                                                                        

libudev: add_to_rules: invalid rule
'/home/alan/Documents/bootup/src/udev/test/udev-test.rules:1'      
remove:      ok

TEST 129: final assignment
device
'/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda'
expecting node 'ok'
libudev: lookup_group: specified group 'nobody'
unknown                                         
Argument "nobody" isn't numeric in numeric ne (!=) at ./udev-test.pl
line 1671.                   
permissions:
ok                                                                                   

add:        
ok                                                                                   

remove:      ok

TEST 144: overlong comment line
device
'/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda1'
expecting node 'yes'
libudev: add_to_rules: invalid KERNEL
operation                                                       
libudev: add_to_rules: invalid rule
'/home/alan/Documents/bootup/src/udev/test/udev-test.rules:1'     
add:        
ok                                                                                       

libudev: add_to_rules: invalid KERNEL
operation                                                       
libudev: add_to_rules: invalid rule
'/home/alan/Documents/bootup/src/udev/test/udev-test.rules:1'
remove:      ok

TEST 146: TEST absolute path
device
'/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda'
expecting node 'there'
libudev: add_to_rules: invalid rule
'/home/alan/Documents/bootup/src/udev/test/udev-test.rules:1'
add:         ok
libudev: add_to_rules: invalid rule
'/home/alan/Documents/bootup/src/udev/test/udev-test.rules:1'
remove:      ok