All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Jike Song <albcamus@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: add missed clobber for 32-bit memmove
Date: Fri, 17 Oct 2008 09:35:45 -0700	[thread overview]
Message-ID: <48F8BEE1.1010000@zytor.com> (raw)
In-Reply-To: <1224249353-3032-2-git-send-email-albcamus@gmail.com>

Jike Song wrote:
> memmove() is implemented by inline assembly. It calls std at first
> and cld at last, but EFLAGS still should be clobbered.

gcc always treats EFLAGS as clobbered on x86.  The "cc" clobber is 
needed on some platforms, but is a noop on x86.

	-hpa

  parent reply	other threads:[~2008-10-17 16:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-17 13:15 [PATCH] x86: add missed clobber for 32-bit memmove Jike Song
2008-10-17 13:15 ` Jike Song
2008-10-17 15:55   ` Jeremy Fitzhardinge
2008-10-17 16:35   ` H. Peter Anvin [this message]
2008-10-20  6:44     ` Jike Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48F8BEE1.1010000@zytor.com \
    --to=hpa@zytor.com \
    --cc=albcamus@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.