From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: kvm@vger.kernel.org, joro@8bytes.org, anthony@codemonkey.ws
Subject: Re: [PATCH 04/10] Implement GIF, clgi and stgi v4
Date: Sun, 19 Oct 2008 12:04:32 +0200 [thread overview]
Message-ID: <48FB0630.4080503@redhat.com> (raw)
In-Reply-To: <69FC60AA-E2F0-489E-B992-C0ECBF792E85@suse.de>
Alexander Graf wrote:
>>> };
>>> +#define HF_GIF_MASK (1 << 0)
>>> +
>>
>> Why not use bool for gif? It will improve code readability.
>
> This way the code is closer to what qemu cpu emulation is doing
> (probably no good reason). Also it allows for more flags to be added
> later on. I originally had a VMLOAD/VMRUN/VMSAVE merging hack, that
> would set the hflag - until I realized that it's not SMP safe.
>
Well, bool is also extensible (add more bools...).
> Nevertheless, I thought it might be better to have something that's
> easily extensible. If you think otherwise, I'd change it, but I like
> the hflags idea in general.
It's a matter of personal preference; I guess it would be silly for me
to insist on such a small point given the massive amount of work that
has gone into this. So I'll leave it up to you.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-10-19 10:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 19:31 [PATCH 00/10] Add support for nested SVM (kernel) v4 Alexander Graf
2008-10-15 19:31 ` [PATCH 01/10] Add CPUID feature flag for SVM v4 Alexander Graf
2008-10-15 19:31 ` [PATCH 02/10] Clean up VINTR setting v4 Alexander Graf
2008-10-15 19:31 ` [PATCH 03/10] Add helper functions for nested SVM v4 Alexander Graf
2008-10-15 19:31 ` [PATCH 04/10] Implement GIF, clgi and stgi v4 Alexander Graf
2008-10-15 19:31 ` [PATCH 05/10] Implement hsave v4 Alexander Graf
2008-10-15 19:31 ` [PATCH 06/10] Add VMLOAD and VMSAVE handlers v4 Alexander Graf
2008-10-15 19:31 ` [PATCH 07/10] Add VMRUN handler v4 Alexander Graf
2008-10-15 19:31 ` [PATCH 08/10] Add VMEXIT handler and intercepts v4 Alexander Graf
2008-10-15 19:31 ` [PATCH 09/10] allow read access to MSR_VM_VR Alexander Graf
2008-10-15 19:31 ` [PATCH 10/10] Allow setting the SVME bit v4 Alexander Graf
2008-10-19 9:51 ` [PATCH 07/10] Add VMRUN handler v4 Avi Kivity
2008-10-19 9:58 ` Alexander Graf
2008-10-19 10:06 ` Avi Kivity
2008-10-19 10:13 ` Alexander Graf
2008-10-19 10:27 ` Avi Kivity
2008-10-19 10:33 ` Alexander Graf
2008-10-19 10:54 ` Avi Kivity
2008-10-19 9:46 ` [PATCH 04/10] Implement GIF, clgi and stgi v4 Avi Kivity
2008-10-19 9:57 ` Alexander Graf
2008-10-19 10:04 ` Avi Kivity [this message]
2008-10-16 11:25 ` [PATCH 01/10] Add CPUID feature flag for SVM v4 Alexander Graf
2008-10-19 9:56 ` [PATCH 00/10] Add support for nested SVM (kernel) v4 Avi Kivity
2008-10-19 10:01 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FB0630.4080503@redhat.com \
--to=avi@redhat.com \
--cc=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.