From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Patrick McHardy <kaber@trash.net>,
Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>
Subject: Re: netfilter: use NFPROTO_* constants in NF_HOOK callsites
Date: Sun, 19 Oct 2008 14:46:34 +0200 [thread overview]
Message-ID: <48FB2C2A.4010209@netfilter.org> (raw)
In-Reply-To: <alpine.LNX.1.10.0810181519520.27947@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> On Saturday 2008-10-18 12:13, Patrick McHardy wrote:
>
>> Jan Engelhardt wrote:
>>> commit cc3e81cbbc8a6977cfe614286de16020f9efa3c6
>>> Author: Jan Engelhardt <jengelh@medozas.de>
>>> Date: Fri Oct 17 10:02:30 2008 -0400
>>>
>>> netfilter: use NFPROTO_* constants in NF_HOOK callsites
>> This is missing arp, the only place that would qualify as bugfix.
>> Please resubmit and add a changelog that explains that is actually
>> fixes something.
>
> I just did that! Or did you already delete the mail and
> marc is down?
> http://marc.info/?l=netfilter-devel&m=122412130603479&w=2
I think that Patrick means that you have to merge both patches and
include the changelog that *explicitly* states that this is not just a
cleanup but a bugfix, otherwise it won't get into 2.6.27.
BTW, include the Reported-by tag. Ingo Molnar recently told us to do so
in all of our patches. I don't care about credits but this is supposed
to be "good practise" to encourage testers.
--
"Los honestos son inadaptados sociales" -- Les Luthiers
next prev parent reply other threads:[~2008-10-19 12:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-16 1:24 [PATCH] netfilter: fix arptable_filter wrong hook registering Pablo Neira Ayuso
2008-10-16 1:41 ` Jan Engelhardt
2008-10-16 1:54 ` Pablo Neira Ayuso
2008-10-16 2:03 ` Jan Engelhardt
2008-10-16 11:52 ` Pablo Neira Ayuso
2008-10-16 11:52 ` Patrick McHardy
2008-10-16 11:56 ` Pablo Neira Ayuso
2008-10-16 11:58 ` Patrick McHardy
2008-10-17 14:20 ` Jan Engelhardt
2008-10-17 14:44 ` netfilter: use NFPROTO_* constants in NF_HOOK callsites Jan Engelhardt
2008-10-18 16:13 ` Patrick McHardy
2008-10-18 19:21 ` Jan Engelhardt
2008-10-19 12:46 ` Pablo Neira Ayuso [this message]
2008-10-17 14:44 ` netfilter: use NFPROTO_* constants in nf_hook_ops structures Jan Engelhardt
2008-10-20 9:54 ` [PATCH] netfilter: fix arptable_filter wrong hook registering Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FB2C2A.4010209@netfilter.org \
--to=pablo@netfilter.org \
--cc=jengelh@medozas.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.