All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timothy Shimmin <tes@sgi.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Miklos Szeredi <miklos@szeredi.hu>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: XFS_ERROR use - was Re: [PATCH] prevent NULL returns from d_obtain_alias
Date: Mon, 20 Oct 2008 11:49:47 +1100	[thread overview]
Message-ID: <48FBD5AB.6090306@sgi.com> (raw)
In-Reply-To: <20081017171000.GC18582@lst.de>

Christoph Hellwig wrote:
>> Fair enough.
>> But XFS_ERROR is used throughout the function.
> 
> Can we leave it the simple way for now?  

Yep.

> I have to revamp that whole
> function anyway as it's extremly buggy in many ways, especially when
> used to open directories (can lead to multiple dentries for a single
> directory - ouch) and then I'll kill the other uses.

Oh ok.

In userspace,
we use it for opening directories on xfsdump via jdm_open in order to
do bulkstat driven dirent dumping.
We also use it in xfsrestore - though I am not convinced we should -
it was initially done for "performance" reasons apparently.

--Tim

  reply	other threads:[~2008-10-20  0:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-15 19:28 [PATCH] prevent NULL returns from d_obtain_alias Christoph Hellwig
2008-10-16 17:50 ` Miklos Szeredi
2008-10-16 18:09   ` Christoph Hellwig
2008-10-17  0:11     ` XFS_ERROR use - was " Timothy Shimmin
2008-10-17  1:53       ` Dave Chinner
2008-10-17  3:04         ` Eric Sandeen
2008-10-17 17:10       ` Christoph Hellwig
2008-10-20  0:49         ` Timothy Shimmin [this message]
2008-10-20  9:23           ` Christoph Hellwig
2008-10-20 23:16             ` Timothy Shimmin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48FBD5AB.6090306@sgi.com \
    --to=tes@sgi.com \
    --cc=hch@lst.de \
    --cc=miklos@szeredi.hu \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.