From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] x86 emulator: Add decode entries for 0x05 opcode
Date: Mon, 20 Oct 2008 09:21:20 +0200
Message-ID: <48FC3170.60904@redhat.com>
References: <20081020085217.68bb3f72@frecb000711>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm <kvm@vger.kernel.org>
To: Guillaume Thouvenin <guillaume.thouvenin@ext.bull.net>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:33193 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750958AbYJTHVr (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 20 Oct 2008 03:21:47 -0400
In-Reply-To: <20081020085217.68bb3f72@frecb000711>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Guillaume Thouvenin wrote:
> Add decode entries for 0x05 (ADD) opcode, execution is already
> implemented.
>
>   

Please send a unit test entry.

Also, why not implement opcode 4 (add al, imm8) at the same time?


-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.