All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <menon.nishanth@gmail.com>
To: felipe.balbi@nokia.com
Cc: linux-omap@vger.kernel.org, Ben Dooks <ben-linux@fluff.org>,
	Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH] i2c: omap: highspeed only over 1000mhz
Date: Mon, 20 Oct 2008 07:42:17 -0500	[thread overview]
Message-ID: <48FC7CA9.4040102@gmail.com> (raw)
In-Reply-To: <20081020102659.GA31599@gandalf.research.nokia.com>

Felipe,
Felipe Balbi said the following on 10/20/2008 05:26 AM:
> up to 1000khz it's Fast Mode+, not highspeed.
>
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
>  drivers/i2c/busses/i2c-omap.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index a999606..53d6244 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -296,7 +296,7 @@ static int omap_i2c_init(struct omap_i2c_dev *dev)
>  		psc = psc - 1;
>  
>  		/* If configured for High Speed */
> -		if (dev->speed > 400) {
> +		if (dev->speed > 1000) {
>   
Ref: http://www.nxp.com/acrobat_download/literature/9398/39340011.pdf
Page 4:
"Serial, 8-bit oriented, bi-directional data transfers can be
made at *up to* 100 kbit/s in the Standard-mode, *up to*
400 kbit/s in the Fast-mode, or *up to* 3.4 Mbit/s in the
High-speed mode"

Why do say high speed is >1000khz?

Thanks and Regards,
Nishanth Menon

  reply	other threads:[~2008-10-20 12:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-17 21:09 [PATCH] i2c: omap: highspeed only over 1000mhz Felipe Balbi
2008-10-17 21:51 ` Ben Dooks
2008-10-17 23:49   ` Felipe Balbi
2008-10-20 10:26 ` Felipe Balbi
2008-10-20 12:42   ` Nishanth Menon [this message]
2008-10-20 12:53     ` Felipe Balbi
     [not found]       ` <48FC851C.3040506@gmail.com>
2008-10-20 13:22         ` Felipe Balbi
2008-10-20 15:15   ` Tony Lindgren
2008-10-20 17:10     ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48FC7CA9.4040102@gmail.com \
    --to=menon.nishanth@gmail.com \
    --cc=ben-linux@fluff.org \
    --cc=felipe.balbi@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.