From: Divy Le Ray <divy@chelsio.com>
To: David Miller <davem@davemloft.net>
Cc: rdreier@cisco.com, jeff@garzik.org, netdev@vger.kernel.org
Subject: Re: cxgb3: Fix kernel crash caused by uninitialized l2t_entry.arpq
Date: Mon, 20 Oct 2008 10:10:20 -0700 [thread overview]
Message-ID: <48FCBB7C.9070504@chelsio.com> (raw)
In-Reply-To: <20081017.163113.225289906.davem@davemloft.net>
David Miller wrote:
> From: Roland Dreier <rdreier@cisco.com>
> Date: Fri, 17 Oct 2008 14:18:26 -0700
>
>
>> Commit 147e70e6 ("cxgb3: Use SKB list interfaces instead of home-grown
>> implementation.") causes a crash in t3_l2t_send_slow() when an iWARP
>> connection request is received. This is because the new l2t_entry.arpq
>> skb queue is never initialized, and therefore trying to add an skb to
>> it causes a NULL dereference. With the old code there was no need to
>> initialize the queues because the l2t_entry structures were zeroed,
>> and the code used NULL to mean empty.
>>
>> Fix this by adding __skb_queue_head_init() when all the l2t_entry
>> structures get allocated.
>>
>> Signed-off-by: Roland Dreier <rolandd@cisco.com>
>>
>
> Acked-by: David S. Miller <davem@davemloft.net>
>
Acked-by: Divy Le ray <divy@chelsio.com>
next prev parent reply other threads:[~2008-10-20 17:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 21:18 cxgb3: Fix kernel crash caused by uninitialized l2t_entry.arpq Roland Dreier
2008-10-17 23:31 ` David Miller
2008-10-20 17:10 ` Divy Le Ray [this message]
2008-10-21 6:10 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FCBB7C.9070504@chelsio.com \
--to=divy@chelsio.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.