From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stas Sergeev Subject: Re: snd_pcsp locking mess Date: Tue, 21 Oct 2008 01:51:57 +0400 Message-ID: <48FCFD7D.6000001@aknet.ru> References: <20080518172258.D0DFB108060@picon.linux-foundation.org> <4830737B.70108@aknet.ru> <4831B260.1060802@aknet.ru> <4835D774.3070306@aknet.ru> <483C10E7.7070203@aknet.ru> <48AD21EF.8010906@aknet.ru> <48AD42A0.9030509@aknet.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.aknet.ru (mail.aknet.ru [78.158.192.26]) by alsa0.perex.cz (Postfix) with ESMTP id AE63D24645 for ; Mon, 20 Oct 2008 23:49:19 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: ALSA devel List-Id: alsa-devel@alsa-project.org Hi. Takashi Iwai wrote: > Indeed, the async trigger is nice to have in the common place. > However, the change wouldn't be as trivial as it sounds, as you > mentioned. By async nature, there can be a transition phase between > the XRUN and STOP, which can cause races. Could you please elaborate on how my proposed patch could possibly affect that? It basically doesn't do anything at all except providing one more callback for what would otherwise had to be done in a trigger() callback anyway. If there is a race with that patch, then I pretty much suspect it was with an old code too. I can't imagine any possible change. What have changed?