From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] FDT include file problems
Date: Mon, 20 Oct 2008 19:43:45 -0400 [thread overview]
Message-ID: <48FD17B1.7070909@gmail.com> (raw)
In-Reply-To: <20081020110844.4326D835697A@gemini.denx.de>
Wolfgang Denk wrote:
> Dear Jerry Van Baren,
>
> In message <48FC5AB3.10302@gmail.com> you wrote:
>> Google hasn't been very helpful for answering the question of how to
>> handle endian issues in userland (non-kernel) code. Hmmm. Grrr. Maybe
>> I'm not asking it the right question.
>
> This patch seems to work for me:
>
> diff --git a/include/libfdt_env.h b/include/libfdt_env.h
> index 671c3a8..355ebf2 100644
> --- a/include/libfdt_env.h
> +++ b/include/libfdt_env.h
> @@ -24,19 +24,28 @@
> #ifdef USE_HOSTCC
> #include <stdint.h>
> #include <string.h>
> +#include <endian.h>
> +#include <byteswap.h>
> #else
> #include <linux/string.h>
> #include <linux/types.h>
> +#include <asm/byteorder.h>
> #endif /* USE_HOSTCC */
>
> #include <stddef.h>
> -#include <asm/byteorder.h>
> extern struct fdt_header *working_fdt; /* Pointer to the working fdt */
>
> -#define fdt32_to_cpu(x) __be32_to_cpu(x)
> -#define cpu_to_fdt32(x) __cpu_to_be32(x)
> -#define fdt64_to_cpu(x) __be64_to_cpu(x)
> -#define cpu_to_fdt64(x) __cpu_to_be64(x)
> +#if __BYTE_ORDER == __LITTLE_ENDIAN
> +#define fdt32_to_cpu(x) bswap_32(x)
> +#define cpu_to_fdt32(x) bswap_32(x)
> +#define fdt64_to_cpu(x) bswap_64(x)
> +#define cpu_to_fdt64(x) bswap_64(x)
> +#else
> +#define fdt32_to_cpu(x) (x)
> +#define cpu_to_fdt32(x) (x)
> +#define fdt64_to_cpu(x) (x)
> +#define cpu_to_fdt64(x) (x)
> +#endif
>
> /*
> * Types for `void *' pointers.
>
> Best regards,
>
> Wolfgang Denk
Dear Wolfgang,
This works for me too. Do you want to apply it directly? That would be
fastest and easiest.
Acked-by: Gerald Van Baren <vanbaren@cideas.com>
Thanks,
gvb
next prev parent reply other threads:[~2008-10-20 23:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-19 22:01 [U-Boot] FDT include file problems Wolfgang Denk
2008-10-20 3:10 ` Jerry Van Baren
2008-10-20 7:23 ` Wolfgang Denk
2008-10-20 10:17 ` Jerry Van Baren
2008-10-20 10:51 ` Wolfgang Denk
2008-10-20 11:08 ` Wolfgang Denk
2008-10-20 23:43 ` Jerry Van Baren [this message]
2008-10-21 9:24 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FD17B1.7070909@gmail.com \
--to=gvb.uboot@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.