From: Jeff Garzik <jeff@garzik.org>
To: roel kluin <roel.kluin@gmail.com>
Cc: ben-linux@fluff.org, netdev@vger.kernel.org
Subject: Re: [PATCH] AX88796: ax_probe() fix irq assignment
Date: Tue, 21 Oct 2008 01:15:16 -0400 [thread overview]
Message-ID: <48FD6564.8090104@garzik.org> (raw)
In-Reply-To: <48FD6C22.8030607@gmail.com>
roel kluin wrote:
> dev->irq is unsigned
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/drivers/net/ax88796.c b/drivers/net/ax88796.c
> index 4207d6e..9a314d8 100644
> --- a/drivers/net/ax88796.c
> +++ b/drivers/net/ax88796.c
> @@ -838,12 +838,12 @@ static int ax_probe(struct platform_device *pdev)
>
> /* find the platform resources */
>
> - dev->irq = platform_get_irq(pdev, 0);
> - if (dev->irq < 0) {
> + ret = platform_get_irq(pdev, 0);
> + if (ret < 0) {
> dev_err(&pdev->dev, "no IRQ specified\n");
> - ret = -ENXIO;
> goto exit_mem;
> }
> + dev->irq = ret;
applied
prev parent reply other threads:[~2008-10-21 5:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 5:44 [PATCH] AX88796: ax_probe() fix irq assignment roel kluin
2008-10-21 5:15 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FD6564.8090104@garzik.org \
--to=jeff@garzik.org \
--cc=ben-linux@fluff.org \
--cc=netdev@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.