From: Jeff Garzik <jgarzik@pobox.com>
To: Dmitry Baryshkov <dbaryshkov@gmail.com>
Cc: netdev@vger.kernel.org, Eric Miao <eric.miao@marvell.com>
Subject: Re: [PATCH] SMC911x: unbreak PXA builds
Date: Tue, 21 Oct 2008 01:15:39 -0400 [thread overview]
Message-ID: <48FD657B.7060307@pobox.com> (raw)
In-Reply-To: <1224549389-13840-1-git-send-email-dbaryshkov@gmail.com>
Dmitry Baryshkov wrote:
> Currently SMC911x driver is broken on ARM/PXA builds.
> Unbreak such configurations.
>
> Signed-off-by: Dmitry Baryshkov <dbaryshkov@gmail.com>
> ---
> drivers/net/smc911x.c | 2 +-
> drivers/net/smc911x.h | 6 ++++--
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
> index ddcefde..402fd06 100644
> --- a/drivers/net/smc911x.c
> +++ b/drivers/net/smc911x.c
> @@ -1241,7 +1241,7 @@ smc911x_rx_dma_irq(int dma, void *data)
> netif_rx(skb);
>
> spin_lock_irqsave(&lp->lock, flags);
> - pkts = (SMC_GET_RX_FIFO_INF() & RX_FIFO_INF_RXSUSED_) >> 16;
> + pkts = (SMC_GET_RX_FIFO_INF(lp) & RX_FIFO_INF_RXSUSED_) >> 16;
> if (pkts != 0) {
> smc911x_rcv(dev);
> }else {
> diff --git a/drivers/net/smc911x.h b/drivers/net/smc911x.h
> index bf6240f..cc7d85b 100644
> --- a/drivers/net/smc911x.h
> +++ b/drivers/net/smc911x.h
> @@ -50,6 +50,10 @@
> #define SMC_DYNAMIC_BUS_CONFIG
> #endif
>
> +#ifdef SMC_USE_PXA_DMA
> +#define SMC_USE_DMA
> +#endif
> +
> /* store this information for the driver.. */
> struct smc911x_local {
> /*
> @@ -196,8 +200,6 @@ static inline void SMC_outsl(struct smc911x_local *lp, int reg,
>
>
> #ifdef SMC_USE_PXA_DMA
> -#define SMC_USE_DMA
applied
prev parent reply other threads:[~2008-10-21 5:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 0:36 [PATCH] SMC911x: unbreak PXA builds Dmitry Baryshkov
2008-10-21 5:15 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FD657B.7060307@pobox.com \
--to=jgarzik@pobox.com \
--cc=dbaryshkov@gmail.com \
--cc=eric.miao@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.