From: Ivan Vecera <ivecera@redhat.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: c4p7n@capitanio.org, netdev@vger.kernel.org, kernel@vger.kernel.org
Subject: Re: [patch] rtl8102e: commit 7bf6bf480 zeroized MAC address
Date: Tue, 21 Oct 2008 13:15:38 +0200 [thread overview]
Message-ID: <48FDB9DA.5020503@redhat.com> (raw)
In-Reply-To: <20081015225023.GB12337@electric-eye.fr.zoreil.com>
Francois Romieu wrote:
> c4p7n@capitanio.org <c4p7n@capitanio.org> :
>> May be we are reading just by luck zeros and not a random perfectly
>> sane address.
>
> I would use the attached patches. The former one is mostly Ivan's one
> with some rework of the debug messages. The later checks the eeprom
> for its signature.
>
> With these patches the driver notices that it can not get an address
> for my 8168b but it works ok with my 8169 after both an hot and a
> cold boot. Interestingly enough, the VPD is not enabled on the 8169
> during the first boot.
>
> Ivan, can you test them (and fix them afterwards :o) ) ?
No problem found. Both 8168c (GIGA_MAC_VER_20) and 8102el (GIGA_MAC_VER_09)
successfully loads MAC address from EEPROM (from power-off state and also
after reboot).
Ivan
next prev parent reply other threads:[~2008-10-21 11:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 13:57 [patch] rtl8102e: commit 7bf6bf480 zeroized MAC address c4p7n
2008-10-15 22:50 ` Francois Romieu
2008-10-16 11:19 ` Martin Capitanio
2008-10-21 11:15 ` Ivan Vecera [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-10-15 10:11 c4p7n
2008-10-15 12:31 ` Ivan Vecera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FDB9DA.5020503@redhat.com \
--to=ivecera@redhat.com \
--cc=c4p7n@capitanio.org \
--cc=kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.