Re: [Qemu-devel] Broken USB support for Linux host

[Anthony Liguori <anthony@codemonkey.ws>]

Bjorn Danielsson wrote:
> Hello everyone, this is a bug report with a suggested patch included.
>
> Summary: usb_host_scan() in usb-linux.c doesn't handle the logic
> correctly when looking for different places to find bus/usb/devices.
>
> Environment: qemu revision 5499 on slamd64 (slackware) 12.1
>
> Symptom: no "host:" usb devices are available at all on any system
> where /proc/bus/usb/devices exists.
>
> Diagnosis: the else clause for the USB_FS_SYS case is wrong.
>   

Thanks for narrowing this down.

Please include a Signed-off-by so we can include your patch.

Regards,

Anthony Liguori

> Solution:
>
> ---cut-here--------------
> Index: usb-linux.c
> ===================================================================
> --- usb-linux.c	(revision 5499)
> +++ usb-linux.c	(working copy)
> @@ -1293,7 +1293,8 @@
>              usb_fs_type = USB_FS_SYS;
>              closedir(dir);
>              dprintf(opened, USBSYSBUS_PATH, devices);
> -        } else {
> +        }
> +        if (!usb_fs_type) {
>              term_printf("husb: unable to access USB devices\n");
>              goto the_end;
>          }
>
> ---cut-here--------------
>
>