diff for duplicates of <48FDDEC0.9040903@sgi.com> diff --git a/a/1.txt b/N1/1.txt index acbb4b9..21e41ef 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -9,11 +9,11 @@ Rusty Russell wrote: > 1) I like the name in this context: it's a beacon of sanity after NR_CPUS and > nr_cpu_ids. But it's not so clearly a win when general code uses it: > -> if (cpumask_first(mymask) = nr_cpumask_bits) ... +> if (cpumask_first(mymask) == nr_cpumask_bits) ... > > vs: > -> if (cpumask_first(mymask) = nr_cpu_ids) ... +> if (cpumask_first(mymask) == nr_cpu_ids) ... I think the correct use for iterators would be: @@ -23,7 +23,7 @@ I think the correct use for iterators would be: is not really meant to be used anywhere except in the bit operations supporting the cpumask_* operators. -> 2) This breaks anyone who tests that the iterators etc. return = nr_cpu_ids. +> 2) This breaks anyone who tests that the iterators etc. return == nr_cpu_ids. I think that's broken anyways... ;-) @@ -32,7 +32,7 @@ I think that's broken anyways... ;-) The change from NR_CPUS to nr_cpu_ids is ok, but it should also be changed from: - (x = NR_CPUS) + (x == NR_CPUS) to: (x <= nr_cpu_ids) @@ -51,7 +51,7 @@ compatibility without allocating unused memory. I'll run the test again but most likely the result will be an extra 1Mb of unused memory instead. ;-) One other note, that test compile used the default -config [and NR_CPUS\x128] which turns off a lot of functions. A typical distro +config [and NR_CPUS=128] which turns off a lot of functions. A typical distro config will have many more options turned on. And the beauty of using a separate flag to enable variable length cpumasks, diff --git a/a/content_digest b/N1/content_digest index a77c77c..456a517 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,26 +3,26 @@ "ref\0200810212326.10278.rusty@rustcorp.com.au\0" "From\0Mike Travis <travis@sgi.com>\0" "Subject\0Re: [PATCH 18/35] cpumask: add nr_cpumask_bits\0" - "Date\0Tue, 21 Oct 2008 13:53:04 +0000\0" + "Date\0Tue, 21 Oct 2008 06:53:04 -0700\0" "To\0Rusty Russell <rusty@rustcorp.com.au>\0" - "Cc\0Ingo Molnar <mingo@elte.hu>" - Andi Kleen <andi@firstfloor.org> - Andrew Morton <akpm@linux-foundation.org> - davej@codemonkey.org.uk - David Miller <davem@davemloft.net> - Eric Dumazet <dada1@cosmosbay.com> - Jack Steiner <steiner@sgi.com> + "Cc\0davej@codemonkey.org.uk" Jeremy Fitzhardinge <jeremy@goop.org> Jes Sorensen <jes@sgi.com> - H. Peter Anvin <hpa@zytor.com> + IA64 <linux-ia64@vger.kernel.org> + David Miller <davem@davemloft.net> peterz@infradead.org + S390 <linux-s390@vger.kernel.org> + Jack Steiner <steiner@sgi.com> + linux-kernel@vger.kernel.org + Eric Dumazet <dada1@cosmosbay.com> + PowerPC <linuxppc-dev@ozlabs.org> + Andi Kleen <andi@firstfloor.org> Thomas Gleixner <tglx@linutronix.de> Yinghai Lu <yhlu.kernel@gmail.com> - IA64 <linux-ia64@vger.kernel.org> - PowerPC <linuxppc-dev@ozlabs.org> - S390 <linux-s390@vger.kernel.org> + H. Peter Anvin <hpa@zytor.com> SPARC <sparclinux@vger.kernel.org> - " linux-kernel@vger.kernel.org\0" + Ingo Molnar <mingo@elte.hu> + " Andrew Morton <akpm@linux-foundation.org>\0" "\00:1\0" "b\0" "Rusty Russell wrote:\n" @@ -36,11 +36,11 @@ "> 1) I like the name in this context: it's a beacon of sanity after NR_CPUS and\n" "> nr_cpu_ids. But it's not so clearly a win when general code uses it:\n" "> \n" - "> \tif (cpumask_first(mymask) = nr_cpumask_bits) ...\n" + "> \tif (cpumask_first(mymask) == nr_cpumask_bits) ...\n" "> \n" "> vs:\n" "> \n" - "> \tif (cpumask_first(mymask) = nr_cpu_ids) ...\n" + "> \tif (cpumask_first(mymask) == nr_cpu_ids) ...\n" "\n" "I think the correct use for iterators would be:\n" "\n" @@ -50,7 +50,7 @@ "is not really meant to be used anywhere except in the bit operations supporting\n" "the cpumask_* operators.\n" "\n" - "> 2) This breaks anyone who tests that the iterators etc. return = nr_cpu_ids.\n" + "> 2) This breaks anyone who tests that the iterators etc. return == nr_cpu_ids.\n" "\n" "I think that's broken anyways... ;-)\n" "\n" @@ -59,7 +59,7 @@ "\n" "The change from NR_CPUS to nr_cpu_ids is ok, but it should also be changed from:\n" "\n" - "\t(x = NR_CPUS)\n" + "\t(x == NR_CPUS)\n" "to:\n" "\t(x <= nr_cpu_ids)\n" " \n" @@ -78,7 +78,7 @@ "\n" "I'll run the test again but most likely the result will be an extra 1Mb of\n" "unused memory instead. ;-) One other note, that test compile used the default\n" - "config [and NR_CPUS\0228] which turns off a lot of functions. A typical distro\n" + "config [and NR_CPUS=128] which turns off a lot of functions. A typical distro\n" "config will have many more options turned on.\n" "\n" "And the beauty of using a separate flag to enable variable length cpumasks,\n" @@ -112,4 +112,4 @@ "Thanks!\n" Mike -3e5f5b4e23a12fb17861a20d18b2093e8d32c0aabba9842886a5e38647cedb4f +6908730240f4da77ccfc78a282579b98a6a88d6bfd68e0a92228c83ef44609d8
diff --git a/a/content_digest b/N2/content_digest index a77c77c..bf20f49 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -5,24 +5,24 @@ "Subject\0Re: [PATCH 18/35] cpumask: add nr_cpumask_bits\0" "Date\0Tue, 21 Oct 2008 13:53:04 +0000\0" "To\0Rusty Russell <rusty@rustcorp.com.au>\0" - "Cc\0Ingo Molnar <mingo@elte.hu>" - Andi Kleen <andi@firstfloor.org> - Andrew Morton <akpm@linux-foundation.org> - davej@codemonkey.org.uk - David Miller <davem@davemloft.net> - Eric Dumazet <dada1@cosmosbay.com> - Jack Steiner <steiner@sgi.com> + "Cc\0davej@codemonkey.org.uk" Jeremy Fitzhardinge <jeremy@goop.org> Jes Sorensen <jes@sgi.com> - H. Peter Anvin <hpa@zytor.com> + IA64 <linux-ia64@vger.kernel.org> + David Miller <davem@davemloft.net> peterz@infradead.org + S390 <linux-s390@vger.kernel.org> + Jack Steiner <steiner@sgi.com> + linux-kernel@vger.kernel.org + Eric Dumazet <dada1@cosmosbay.com> + PowerPC <linuxppc-dev@ozlabs.org> + Andi Kleen <andi@firstfloor.org> Thomas Gleixner <tglx@linutronix.de> Yinghai Lu <yhlu.kernel@gmail.com> - IA64 <linux-ia64@vger.kernel.org> - PowerPC <linuxppc-dev@ozlabs.org> - S390 <linux-s390@vger.kernel.org> + H. Peter Anvin <hpa@zytor.com> SPARC <sparclinux@vger.kernel.org> - " linux-kernel@vger.kernel.org\0" + Ingo Molnar <mingo@elte.hu> + " Andrew Morton <akpm@linux-foundation.org>\0" "\00:1\0" "b\0" "Rusty Russell wrote:\n" @@ -112,4 +112,4 @@ "Thanks!\n" Mike -3e5f5b4e23a12fb17861a20d18b2093e8d32c0aabba9842886a5e38647cedb4f +2100ce21d616719bc3be62ac9a3e87c464663009eec5e41af3466739365b661e
diff --git a/a/1.txt b/N3/1.txt index acbb4b9..21e41ef 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -9,11 +9,11 @@ Rusty Russell wrote: > 1) I like the name in this context: it's a beacon of sanity after NR_CPUS and > nr_cpu_ids. But it's not so clearly a win when general code uses it: > -> if (cpumask_first(mymask) = nr_cpumask_bits) ... +> if (cpumask_first(mymask) == nr_cpumask_bits) ... > > vs: > -> if (cpumask_first(mymask) = nr_cpu_ids) ... +> if (cpumask_first(mymask) == nr_cpu_ids) ... I think the correct use for iterators would be: @@ -23,7 +23,7 @@ I think the correct use for iterators would be: is not really meant to be used anywhere except in the bit operations supporting the cpumask_* operators. -> 2) This breaks anyone who tests that the iterators etc. return = nr_cpu_ids. +> 2) This breaks anyone who tests that the iterators etc. return == nr_cpu_ids. I think that's broken anyways... ;-) @@ -32,7 +32,7 @@ I think that's broken anyways... ;-) The change from NR_CPUS to nr_cpu_ids is ok, but it should also be changed from: - (x = NR_CPUS) + (x == NR_CPUS) to: (x <= nr_cpu_ids) @@ -51,7 +51,7 @@ compatibility without allocating unused memory. I'll run the test again but most likely the result will be an extra 1Mb of unused memory instead. ;-) One other note, that test compile used the default -config [and NR_CPUS\x128] which turns off a lot of functions. A typical distro +config [and NR_CPUS=128] which turns off a lot of functions. A typical distro config will have many more options turned on. And the beauty of using a separate flag to enable variable length cpumasks, diff --git a/a/content_digest b/N3/content_digest index a77c77c..4f77b9c 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -3,7 +3,7 @@ "ref\0200810212326.10278.rusty@rustcorp.com.au\0" "From\0Mike Travis <travis@sgi.com>\0" "Subject\0Re: [PATCH 18/35] cpumask: add nr_cpumask_bits\0" - "Date\0Tue, 21 Oct 2008 13:53:04 +0000\0" + "Date\0Tue, 21 Oct 2008 06:53:04 -0700\0" "To\0Rusty Russell <rusty@rustcorp.com.au>\0" "Cc\0Ingo Molnar <mingo@elte.hu>" Andi Kleen <andi@firstfloor.org> @@ -36,11 +36,11 @@ "> 1) I like the name in this context: it's a beacon of sanity after NR_CPUS and\n" "> nr_cpu_ids. But it's not so clearly a win when general code uses it:\n" "> \n" - "> \tif (cpumask_first(mymask) = nr_cpumask_bits) ...\n" + "> \tif (cpumask_first(mymask) == nr_cpumask_bits) ...\n" "> \n" "> vs:\n" "> \n" - "> \tif (cpumask_first(mymask) = nr_cpu_ids) ...\n" + "> \tif (cpumask_first(mymask) == nr_cpu_ids) ...\n" "\n" "I think the correct use for iterators would be:\n" "\n" @@ -50,7 +50,7 @@ "is not really meant to be used anywhere except in the bit operations supporting\n" "the cpumask_* operators.\n" "\n" - "> 2) This breaks anyone who tests that the iterators etc. return = nr_cpu_ids.\n" + "> 2) This breaks anyone who tests that the iterators etc. return == nr_cpu_ids.\n" "\n" "I think that's broken anyways... ;-)\n" "\n" @@ -59,7 +59,7 @@ "\n" "The change from NR_CPUS to nr_cpu_ids is ok, but it should also be changed from:\n" "\n" - "\t(x = NR_CPUS)\n" + "\t(x == NR_CPUS)\n" "to:\n" "\t(x <= nr_cpu_ids)\n" " \n" @@ -78,7 +78,7 @@ "\n" "I'll run the test again but most likely the result will be an extra 1Mb of\n" "unused memory instead. ;-) One other note, that test compile used the default\n" - "config [and NR_CPUS\0228] which turns off a lot of functions. A typical distro\n" + "config [and NR_CPUS=128] which turns off a lot of functions. A typical distro\n" "config will have many more options turned on.\n" "\n" "And the beauty of using a separate flag to enable variable length cpumasks,\n" @@ -112,4 +112,4 @@ "Thanks!\n" Mike -3e5f5b4e23a12fb17861a20d18b2093e8d32c0aabba9842886a5e38647cedb4f +69ab62fa8ef8e310cf7746a348a94f02b549e3521f66e75c8727b125eddd30b0
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.