All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (adt7473) Fix voltage conversion
Date: Tue, 21 Oct 2008 14:55:27 +0000	[thread overview]
Message-ID: <48FDED5F.1080403@teltonika.lt> (raw)
In-Reply-To: <20081021161730.2a6ddb72@hyperion.delvare>

Jean Delvare wrote:
> Hi Darrick,
> 
> Back in April 2008, Paulius Zaleckas posted a patch fixing the voltage
> conversion routines of the adt7473 hwmon driver [1]. I reviewed it and
> asked for a cleaned up version [2] but Paulius never replied and the
> patch was lost. Still, I think this was a good patch so I just did the
> cleanup work and am going to push the patch to Linus in the next days.

Thanks for picking it up! I had no time to finish it...

> Can you please review and ack the patch below? I tested it on an
> emulated chip and it seems to work fine.

Unfortunately I don't have real hardware to test it... My patch was based
on datasheet... Althrough I had written ADT7476 driver(tested) and it was
based on adt7473 driver, thats how I noticed wrong value calculation.

> Thanks.

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

      reply	other threads:[~2008-10-21 14:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-21 14:17 [lm-sensors] [PATCH] hwmon: (adt7473) Fix voltage conversion Jean Delvare
2008-10-21 14:55 ` Paulius Zaleckas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48FDED5F.1080403@teltonika.lt \
    --to=paulius.zaleckas@teltonika.lt \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.