From: Jason Wessel <jason.wessel@windriver.com>
To: kgdb-bugreport@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH 5/7] kgdboc, tty: use tty open to start low level drivers
Date: Tue, 21 Oct 2008 16:49:09 -0500 [thread overview]
Message-ID: <48FE4E55.90601@windriver.com> (raw)
In-Reply-To: <1224616493-23237-6-git-send-email-jason.wessel@windriver.com>
Jason Wessel wrote:
> A few minor changes were needed in tty_io.c to deal with the fact that
> the inode and fpath.dentry were NULL with the generic flip structure.
>
After further testing and review one patch hunk has been eliminated.
> Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
> ---
> drivers/char/tty_io.c | 96 +++++++++++++++++++++++++++++++++++++++++---
> drivers/serial/kgdboc.c | 26 ++++++++----
> include/linux/tty_driver.h | 5 ++
> 3 files changed, 113 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
> index fa44e6b..fe500ec 100644
> --- a/drivers/char/tty_io.c
> +++ b/drivers/char/tty_io.c
> @@ -1723,7 +1806,7 @@ void tty_release_dev(struct file *filp)
> release_tty(tty, idx);
>
> /* Make this pty number available for reallocation */
> - if (devpts)
> + if (devpts && inode)
> devpts_kill_index(inode, idx);
> }
>
Specifically the call to devpts_kill_index() should get executed
and the above patch hunk has been removed.
Thanks,
Jason.
next prev parent reply other threads:[~2008-10-21 21:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 19:14 kgdb 2.6.28 merge plans Jason Wessel
2008-10-21 19:14 ` [PATCH 1/7] kgdb: Add the ability to schedule a breakpoint via a tasklet Jason Wessel
2008-10-21 19:14 ` [PATCH 2/7] tty: Fix sparse static warning for tty_driver_lookup_tty Jason Wessel
2008-10-21 19:14 ` [PATCH 3/7] kgdboc, tty: Add the rx polling call back capability Jason Wessel
2008-10-21 19:14 ` [PATCH 4/7] kgdboc, 8250: Add the rx polling hook to 8250 driver Jason Wessel
2008-10-21 19:14 ` [PATCH 5/7] kgdboc, tty: use tty open to start low level drivers Jason Wessel
2008-10-21 19:14 ` [PATCH 6/7] kgdb: kgdboc console poll hooks for serial_txx9 uart Jason Wessel
2008-10-21 19:14 ` [PATCH 7/7] kgdb: Make mem access function weak in kgdb.c andkgdb.h Jason Wessel
2008-10-21 21:49 ` Jason Wessel [this message]
2008-10-21 22:47 ` [PATCH 5/7] kgdboc, tty: use tty open to start low level drivers Alan Cox
2008-10-22 1:54 ` Jason Wessel
2008-10-21 22:49 ` kgdb 2.6.28 merge plans Alan Cox
2008-10-22 2:09 ` Jason Wessel
2008-10-22 8:34 ` Alan Cox
2008-10-22 10:07 ` Jason Wessel
2008-10-22 12:25 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FE4E55.90601@windriver.com \
--to=jason.wessel@windriver.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.