All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] [ARM] Apollon UBI support
Date: Tue, 21 Oct 2008 17:30:18 -0700	[thread overview]
Message-ID: <48FE741A.6050408@gmail.com> (raw)
In-Reply-To: <9c9fda240810211717r447103b8pc29384991786e1af@mail.gmail.com>

Hi Kyungmin,

Kyungmin Park wrote:
> Dear Wolfgang,
>
>   
>>> -# define     CONFIG_BOOTARGS "root=/dev/nfs rw mem=64M console=ttyS0,115200n8 ip=192.168.116.25:192.168.116.1:192.168.116.1:255.255.255.0:apollon:eth0:off nfsroot=/tftpboot/nfsroot profile=2"
>>> +# define     CONFIG_BOOTARGS "root=/dev/nfs rw mem=64M console=ttyS0,115200n8 ip=192.168.116.25:192.168.116.1:192.168.116.1:255.255.255.0:apollon:eth0:off nfsroot=/tftpboot/nfsroot profile=2 lpj=1646592 ubi.mtd=4"
>>>  #else
>>> -# define     CONFIG_BOOTARGS "root=/dev/nfs rw mem=128M console=ttyS0,115200n8 ip=192.168.116.25:192.168.116.1:192.168.116.1:255.255.255.0:apollon:eth0:off nfsroot=/tftpboot/nfsroot profile=2"
>>> +# define     CONFIG_BOOTARGS "root=/dev/nfs rw mem=128M console=ttyS0,115200n8 ip=192.168.116.25:192.168.116.1:192.168.116.1:255.255.255.0:apollon:eth0:off nfsroot=/tftpboot/nfsroot profile=2 lpj=1646592 ubi.mtd=4"
>>>       
>> Maximum line length exceeded.
>>
>>     
>
> Fixed all commented except one.
> I run the checkpatch.pl and passed.
>
>   
>> And please do not hard-code network parameters into U-Boot.
>>
>>     
>
> Then how to define the network IP at bootargs? please give some example?
>   
You set environment variables (ie. setenv bootcmd ...)

regards,
Ben

      reply	other threads:[~2008-10-22  0:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-21  9:19 [U-Boot] [PATCH] [ARM] Apollon UBI support Kyungmin Park
2008-10-21 10:20 ` Jean-Christophe PLAGNIOL-VILLARD
2008-10-21 10:27 ` Wolfgang Denk
2008-10-22  0:17   ` Kyungmin Park
2008-10-22  0:30     ` Ben Warren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48FE741A.6050408@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.