From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: x86: Don't deliver PIC interrupts to disabled APICs - v2 Date: Wed, 22 Oct 2008 12:22:20 +0200 Message-ID: <48FEFEDC.5010805@redhat.com> References: <48FC4671.90409@siemens.com> <48FC7435.4020707@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel , "Yang, Sheng" To: Jan Kiszka Return-path: Received: from mx2.redhat.com ([66.187.237.31]:47359 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751380AbYJVKW0 (ORCPT ); Wed, 22 Oct 2008 06:22:26 -0400 In-Reply-To: <48FC7435.4020707@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: > [ taking Sheng's comments into account ] > > The logic of kvm_apic_accept_pic_intr has a minor, practically hardly > relevant incorrectness: PIC interrupts are still delivered even if the > APIC of VPU0 (BSP) is disabled. This does not comply with the Virtual > Wire mode according to the Intel MP spec. > Applied, thanks. -- error compiling committee.c: too many arguments to function