From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm: fix unifdef problem Date: Wed, 22 Oct 2008 12:31:11 +0200 Message-ID: <48FF00EF.3060706@redhat.com> References: <1224574264-27116-1-git-send-email-sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:33698 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753516AbYJVKcP (ORCPT ); Wed, 22 Oct 2008 06:32:15 -0400 In-Reply-To: <1224574264-27116-1-git-send-email-sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Sheng Yang wrote: > Reminder by Avi, unifdef need a -U parameter to deal undefined macro, other wise > it can't deal with #if defined() || defined(). > > Also fix a historic bug on never execute unifdef... > > Also discard "set -e" before unifdef, because unifdef would return 1 if it have > done something to the file. > > Applied, thanks. -- error compiling committee.c: too many arguments to function