From: Matt Sealey <matt@genesi-usa.com>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: Scott Wood <scottwood@freescale.com>,
linuxppc-dev@ozlabs.org,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Subject: Re: [PATCH] powerpc: Remove device_type = "rtc" properties in .dts files
Date: Wed, 22 Oct 2008 08:38:03 -0500 [thread overview]
Message-ID: <48FF2CBB.7060605@genesi-usa.com> (raw)
In-Reply-To: <20081021185844.GA31070@oksana.dev.rtsoft.ru>
I'm extremely troubled that it is "not used in the code",
surely device_type is checked as a legacy for Open Firmware
(otherwise a lot of devices may never be detected!), or does
device tree parsing/checking follow a different path for FDT?
(absolutely fine with it being removed from new DTS but, just
concerned about your comment and it's impact...)
--
Matt Sealey <matt@genesi-usa.com>
Genesi, Manager, Developer Relations
Anton Vorontsov wrote:
> We don't want to encourage the device_type usage. It isn't used in the
> code, so we can simply remove it from the dts files.
>
> Suggested-by: Scott Wood <scottwood@freescale.com>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> arch/powerpc/boot/dts/kuroboxHD.dts | 1 -
> arch/powerpc/boot/dts/kuroboxHG.dts | 1 -
> arch/powerpc/boot/dts/lite5200.dts | 1 -
> arch/powerpc/boot/dts/lite5200b.dts | 1 -
> arch/powerpc/boot/dts/motionpro.dts | 1 -
> arch/powerpc/boot/dts/mpc8315erdb.dts | 1 -
> arch/powerpc/boot/dts/mpc8349emitx.dts | 1 -
> arch/powerpc/boot/dts/mpc8349emitxgp.dts | 1 -
> arch/powerpc/boot/dts/mpc8377_rdb.dts | 1 -
> arch/powerpc/boot/dts/mpc8378_rdb.dts | 1 -
> arch/powerpc/boot/dts/mpc8379_rdb.dts | 1 -
> arch/powerpc/boot/dts/pcm030.dts | 2 --
> arch/powerpc/boot/dts/tqm5200.dts | 1 -
> 13 files changed, 0 insertions(+), 14 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/kuroboxHD.dts b/arch/powerpc/boot/dts/kuroboxHD.dts
> index 2e5a1a1..8d725d1 100644
> --- a/arch/powerpc/boot/dts/kuroboxHD.dts
> +++ b/arch/powerpc/boot/dts/kuroboxHD.dts
> @@ -76,7 +76,6 @@ XXXX add flash parts, rtc, ??
> interrupt-parent = <&mpic>;
>
> rtc@32 {
> - device_type = "rtc";
> compatible = "ricoh,rs5c372a";
> reg = <0x32>;
> };
> diff --git a/arch/powerpc/boot/dts/kuroboxHG.dts b/arch/powerpc/boot/dts/kuroboxHG.dts
> index e4916e6..b13a11e 100644
> --- a/arch/powerpc/boot/dts/kuroboxHG.dts
> +++ b/arch/powerpc/boot/dts/kuroboxHG.dts
> @@ -76,7 +76,6 @@ XXXX add flash parts, rtc, ??
> interrupt-parent = <&mpic>;
>
> rtc@32 {
> - device_type = "rtc";
> compatible = "ricoh,rs5c372a";
> reg = <0x32>;
> };
> diff --git a/arch/powerpc/boot/dts/lite5200.dts b/arch/powerpc/boot/dts/lite5200.dts
> index 2cf9a87..3f7a5dc 100644
> --- a/arch/powerpc/boot/dts/lite5200.dts
> +++ b/arch/powerpc/boot/dts/lite5200.dts
> @@ -130,7 +130,6 @@
>
> rtc@800 { // Real time clock
> compatible = "fsl,mpc5200-rtc";
> - device_type = "rtc";
> reg = <0x800 0x100>;
> interrupts = <1 5 0 1 6 0>;
> interrupt-parent = <&mpc5200_pic>;
> diff --git a/arch/powerpc/boot/dts/lite5200b.dts b/arch/powerpc/boot/dts/lite5200b.dts
> index 7bd5b9c..63e3bb4 100644
> --- a/arch/powerpc/boot/dts/lite5200b.dts
> +++ b/arch/powerpc/boot/dts/lite5200b.dts
> @@ -130,7 +130,6 @@
>
> rtc@800 { // Real time clock
> compatible = "fsl,mpc5200b-rtc","fsl,mpc5200-rtc";
> - device_type = "rtc";
> reg = <0x800 0x100>;
> interrupts = <1 5 0 1 6 0>;
> interrupt-parent = <&mpc5200_pic>;
> diff --git a/arch/powerpc/boot/dts/motionpro.dts b/arch/powerpc/boot/dts/motionpro.dts
> index 9e3c921..52ba6f9 100644
> --- a/arch/powerpc/boot/dts/motionpro.dts
> +++ b/arch/powerpc/boot/dts/motionpro.dts
> @@ -248,7 +248,6 @@
> fsl5200-clocking;
>
> rtc@68 {
> - device_type = "rtc";
> compatible = "dallas,ds1339";
> reg = <0x68>;
> };
> diff --git a/arch/powerpc/boot/dts/mpc8315erdb.dts b/arch/powerpc/boot/dts/mpc8315erdb.dts
> index 6b85067..d3d3097 100644
> --- a/arch/powerpc/boot/dts/mpc8315erdb.dts
> +++ b/arch/powerpc/boot/dts/mpc8315erdb.dts
> @@ -117,7 +117,6 @@
> interrupt-parent = <&ipic>;
> dfsrr;
> rtc@68 {
> - device_type = "rtc";
> compatible = "dallas,ds1339";
> reg = <0x68>;
> };
> diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/boot/dts/mpc8349emitx.dts
> index 2c9d54a..d86c6a3 100644
> --- a/arch/powerpc/boot/dts/mpc8349emitx.dts
> +++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
> @@ -85,7 +85,6 @@
> dfsrr;
>
> rtc@68 {
> - device_type = "rtc";
> compatible = "dallas,ds1339";
> reg = <0x68>;
> interrupts = <18 0x8>;
> diff --git a/arch/powerpc/boot/dts/mpc8349emitxgp.dts b/arch/powerpc/boot/dts/mpc8349emitxgp.dts
> index fa40647..fd4bbc4 100644
> --- a/arch/powerpc/boot/dts/mpc8349emitxgp.dts
> +++ b/arch/powerpc/boot/dts/mpc8349emitxgp.dts
> @@ -83,7 +83,6 @@
> dfsrr;
>
> rtc@68 {
> - device_type = "rtc";
> compatible = "dallas,ds1339";
> reg = <0x68>;
> interrupts = <18 0x8>;
> diff --git a/arch/powerpc/boot/dts/mpc8377_rdb.dts b/arch/powerpc/boot/dts/mpc8377_rdb.dts
> index 435ef3d..9fe8e4c 100644
> --- a/arch/powerpc/boot/dts/mpc8377_rdb.dts
> +++ b/arch/powerpc/boot/dts/mpc8377_rdb.dts
> @@ -117,7 +117,6 @@
> interrupt-parent = <&ipic>;
> dfsrr;
> rtc@68 {
> - device_type = "rtc";
> compatible = "dallas,ds1339";
> reg = <0x68>;
> };
> diff --git a/arch/powerpc/boot/dts/mpc8378_rdb.dts b/arch/powerpc/boot/dts/mpc8378_rdb.dts
> index b11e68f..3a6d528 100644
> --- a/arch/powerpc/boot/dts/mpc8378_rdb.dts
> +++ b/arch/powerpc/boot/dts/mpc8378_rdb.dts
> @@ -117,7 +117,6 @@
> interrupt-parent = <&ipic>;
> dfsrr;
> rtc@68 {
> - device_type = "rtc";
> compatible = "dallas,ds1339";
> reg = <0x68>;
> };
> diff --git a/arch/powerpc/boot/dts/mpc8379_rdb.dts b/arch/powerpc/boot/dts/mpc8379_rdb.dts
> index 337af6e..ee64def 100644
> --- a/arch/powerpc/boot/dts/mpc8379_rdb.dts
> +++ b/arch/powerpc/boot/dts/mpc8379_rdb.dts
> @@ -117,7 +117,6 @@
> interrupt-parent = <&ipic>;
> dfsrr;
> rtc@68 {
> - device_type = "rtc";
> compatible = "dallas,ds1339";
> reg = <0x68>;
> };
> diff --git a/arch/powerpc/boot/dts/pcm030.dts b/arch/powerpc/boot/dts/pcm030.dts
> index 7c1bb95..be2c11c 100644
> --- a/arch/powerpc/boot/dts/pcm030.dts
> +++ b/arch/powerpc/boot/dts/pcm030.dts
> @@ -143,7 +143,6 @@
>
> rtc@800 { // Real time clock
> compatible = "fsl,mpc5200b-rtc","fsl,mpc5200-rtc";
> - device_type = "rtc";
> reg = <0x800 0x100>;
> interrupts = <0x1 0x5 0x0 0x1 0x6 0x0>;
> interrupt-parent = <&mpc5200_pic>;
> @@ -301,7 +300,6 @@
> interrupt-parent = <&mpc5200_pic>;
> fsl5200-clocking;
> rtc@51 {
> - device_type = "rtc";
> compatible = "nxp,pcf8563";
> reg = <0x51>;
> };
> diff --git a/arch/powerpc/boot/dts/tqm5200.dts b/arch/powerpc/boot/dts/tqm5200.dts
> index 3008bf8..906302e 100644
> --- a/arch/powerpc/boot/dts/tqm5200.dts
> +++ b/arch/powerpc/boot/dts/tqm5200.dts
> @@ -181,7 +181,6 @@
> fsl5200-clocking;
>
> rtc@68 {
> - device_type = "rtc";
> compatible = "dallas,ds1307";
> reg = <0x68>;
> };
next prev parent reply other threads:[~2008-10-22 13:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 18:58 [PATCH] powerpc: Remove device_type = "rtc" properties in .dts files Anton Vorontsov
2008-10-21 19:37 ` Grant Likely
2008-10-22 0:04 ` David Gibson
2008-10-22 13:38 ` Matt Sealey [this message]
2008-10-22 13:50 ` Anton Vorontsov
2008-10-22 18:40 ` Matt Sealey
2008-10-22 18:59 ` Anton Vorontsov
2008-10-22 19:09 ` Matt Sealey
2008-10-22 19:28 ` Anton Vorontsov
[not found] <C3C48FF2CBB.7060605@genesi-usa.com>
2008-10-22 20:38 ` Milton Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FF2CBB.7060605@genesi-usa.com \
--to=matt@genesi-usa.com \
--cc=avorontsov@ru.mvista.com \
--cc=g.liakhovetski@gmx.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.