From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: kvm-devel <kvm@vger.kernel.org>, "Yang, Sheng" <sheng.yang@intel.com>
Subject: Re: [PATCH] KVM: x86: Don't deliver PIC interrupts to disabled APICs - v2
Date: Wed, 22 Oct 2008 16:08:09 +0200 [thread overview]
Message-ID: <48FF33C9.40106@redhat.com> (raw)
In-Reply-To: <48FC7435.4020707@siemens.com>
Jan Kiszka wrote:
> [ taking Sheng's comments into account ]
>
> The logic of kvm_apic_accept_pic_intr has a minor, practically hardly
> relevant incorrectness: PIC interrupts are still delivered even if the
> APIC of VPU0 (BSP) is disabled. This does not comply with the Virtual
> Wire mode according to the Intel MP spec.
>
This breaks Windows XP with the Standard PC HAL, so I am unapplying this
patch.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-10-22 14:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 8:50 [PATCH] KVM: x86: Don't deliver PIC interrupts to disabled APICs Jan Kiszka
2008-10-20 11:51 ` Sheng Yang
2008-10-20 11:56 ` Jan Kiszka
2008-10-20 12:02 ` Jan Kiszka
2008-10-20 12:06 ` [PATCH] KVM: x86: Don't deliver PIC interrupts to disabled APICs - v2 Jan Kiszka
2008-10-20 12:22 ` Sheng Yang
2008-10-22 10:22 ` Avi Kivity
2008-10-22 14:08 ` Avi Kivity [this message]
2008-10-22 15:09 ` Jan Kiszka
2008-10-22 15:12 ` Jan Kiszka
2008-10-22 15:39 ` Jan Kiszka
2008-10-22 20:44 ` Jan Kiszka
2008-10-23 1:51 ` Yang, Sheng
2008-10-23 8:11 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FF33C9.40106@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=sheng.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.