From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758814AbYJVRyu (ORCPT ); Wed, 22 Oct 2008 13:54:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755046AbYJVRyk (ORCPT ); Wed, 22 Oct 2008 13:54:40 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:59946 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755114AbYJVRyj (ORCPT ); Wed, 22 Oct 2008 13:54:39 -0400 Message-ID: <48FF6800.20705@cs.helsinki.fi> Date: Wed, 22 Oct 2008 20:50:56 +0300 From: Pekka Enberg User-Agent: Thunderbird 2.0.0.17 (Macintosh/20080914) MIME-Version: 1.0 To: Christoph Lameter CC: Cyrill Gorcunov , LKML Subject: Re: [RFC] SLUB - define OO_ macro instead of hardcoded numbers References: <20081022161836.GG9639@localhost> <20081022163530.GH9639@localhost> <20081022165354.GI9639@localhost> <20081022172103.GJ9639@localhost> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph Lameter wrote: > On Wed, 22 Oct 2008, Cyrill Gorcunov wrote: > >> Christoph how about this one? > > Ok. Looks a bit better but we still have two maxes here > > s->max which refers to the maximum number of objects per slab page for a > specific slab cache (depends on the runtime configuration). OO_MAX_OBJS > refers to the maximum number of objects per slab page that any slab > cache can be configured for which is a compile time limit. > > Maybe this is okay, Pekka? Maybe call the page->objects maximum MAX_OBJS_PER_PAGE as it's not strictly related to the other OO code? Pekka