From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Elias Oltmanns <eo@nebensachen.de>, linux-ide@vger.kernel.org
Subject: Re: [PATCH 4/4] libata: clean up the SFF code for coding style
Date: Wed, 22 Oct 2008 20:35:42 -0400 [thread overview]
Message-ID: <48FFC6DE.7060605@garzik.org> (raw)
In-Reply-To: <20081022170218.32122780@lxorguk.ukuu.org.uk>
Alan Cox wrote:
>>> if (ata_is_atapi(qc->tf.protocol) &&
>>> - !(qc->dev->flags & ATA_DFLAG_CDB_INTR))
>>> + !(qc->dev->flags & ATA_DFLAG_CDB_INTR))
>> Ditto.
>
> Its lining up the bracketing but hey I'm not fussed, just twiddling where
> checkpatch warned and the like.
>
>>> - err_out:
>>> +err_out:
>> Yes, I've wondered about these myself occasionally. Personally, I don't
>> insert a blank before those labels either and would be in favour of such
>> a change. But do we actually have a convention regarding this matter?
>
> CodingStyle chapter 7 which is of course overridable by Jeff ;)
libata style has always matched that: labels go in column 1, without
any preceding whitespace.
Jeff
next prev parent reply other threads:[~2008-10-23 0:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 18:08 [PATCH 0/4] Small set of further libata patches Alan Cox
2008-10-17 18:08 ` [PATCH 1/4] pata_ninja32: suspend/resume support Alan Cox
2008-10-28 4:42 ` Jeff Garzik
2008-10-28 9:37 ` Alan Cox
2008-10-17 18:08 ` [PATCH 2/4] libata: Drain data on errors Alan Cox
2008-10-22 15:46 ` Elias Oltmanns
2008-10-22 16:44 ` Alan Cox
2008-10-27 19:14 ` Mark Lord
2008-10-27 21:54 ` Alan Cox
2008-10-17 18:08 ` [PATCH 3/4] libata: Improve timeout handling Alan Cox
2008-10-22 15:47 ` Elias Oltmanns
2008-10-22 16:04 ` Alan Cox
2008-10-17 18:09 ` [PATCH 4/4] libata: clean up the SFF code for coding style Alan Cox
2008-10-22 15:48 ` Elias Oltmanns
2008-10-22 16:02 ` Alan Cox
2008-10-23 0:35 ` Jeff Garzik [this message]
2008-10-28 1:49 ` Tejun Heo
2008-10-28 9:47 ` Elias Oltmanns
2008-10-29 2:05 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FFC6DE.7060605@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=eo@nebensachen.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.