From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH #upstream-fixes] libata: set device class to NONE if phys_offline
Date: Wed, 22 Oct 2008 20:42:58 -0400 [thread overview]
Message-ID: <48FFC892.3020608@garzik.org> (raw)
In-Reply-To: <48FDF5D6.20707@kernel.org>
Tejun Heo wrote:
> Reset methods don't have access to phys link status for slave links
> and may incorrectly indicate device presence causing unnecessary probe
> failures for unoccupied links. This patch clears device class to NONE
> during post-reset processing if phys link is offline.
>
> As on/offliness semantics is strictly defined and used in multiple
> places by the core layer, this won't change behavior for drivers which
> don't use slave links.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> ---
> vt8251 incorrectly reports the same signature for unoccupied device if
> the other device on the channel is present. This patch fixes the
> problem.
>
> I integrated this patch into separate-sff-bmdma git tree.
>
> drivers/ata/libata-eh.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
applied
prev parent reply other threads:[~2008-10-23 0:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 15:31 [PATCH #upstream-fixes] libata: set device class to NONE if phys_offline Tejun Heo
2008-10-22 10:23 ` Sergei Shtylyov
2008-10-23 3:01 ` Tejun Heo
2008-10-23 0:42 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FFC892.3020608@garzik.org \
--to=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.