All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Peterson <joe@skyrush.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] fix n_tty/pty input/output buffer full and other misc char handling
Date: Wed, 22 Oct 2008 19:33:30 -0600	[thread overview]
Message-ID: <48FFD46A.9040809@skyrush.com> (raw)
In-Reply-To: <20081022103259.2d04729a@lxorguk.ukuu.org.uk>

Alan,

I have separated this patch into its separate components, since I know
we are still thinking about how to address the pty "gridlock" issue, and
at least two of the other issues addressed can probably be fixed now.

I will shortly send out 4 new patches that replace the original combined
"tty-fix-buffer-full-handling.patch" patch (these all will apply, in
order, on top of your current tty git tree):

	1) n-tty-fix-cont-and-ctrl-output.patch
	2) n-tty-fix-buffer-full-checks.patch

These two can probably be applied and tested now, since I believe these
are straightforward fixes.  #1 simply fixes what looks like an oversight
in the output block processing WRT continuation chars and ctrl chars.
#2 fixes what appear to be problems that cause loss of characters
because of errors in handling situations when the input buffer is full
or nearly so.

	3) n-tty-output-bells-immediately.patch
	4) n-tty-fix-buffer-full-gridlock.patch

These are the ones that we are still discussing.

Hope this splitting up of the patch helps!

							-Joe

  parent reply	other threads:[~2008-10-23  1:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-13  6:01 [PATCH] fix n_tty/pty input/output buffer full and other misc char handling Joe Peterson
2008-10-13  8:40 ` Alan Cox
2008-10-22  9:32 ` Alan Cox
2008-10-22 19:35   ` Joe Peterson
2008-10-23  1:33   ` Joe Peterson [this message]
2008-10-23  1:34   ` [PATCH] n-tty-fix-cont-and-ctrl-output Joe Peterson
2008-10-24  8:57     ` Alan Cox
2008-10-23  1:35   ` [PATCH] n-tty-fix-buffer-full-checks Joe Peterson
2008-10-23  1:35   ` [PATCH] n-tty-output-bells-immediately Joe Peterson
2008-10-24  9:10     ` Alan Cox
2008-10-25 15:41       ` Joe Peterson
2008-10-25 15:48         ` Alan Cox
2008-10-25 15:53           ` Joe Peterson
2008-10-25 21:13             ` Joe Peterson
2008-10-23  1:36   ` [PATCH] n-tty-fix-buffer-full-gridlock Joe Peterson
2008-10-23  1:56     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48FFD46A.9040809@skyrush.com \
    --to=joe@skyrush.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.