All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Grant Grundler <grundler@parisc-linux.org>,
	Matthew Wilcox <matthew@wil.cx>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: [PATCH] pci: show dma_mask bits in /sys
Date: Wed, 22 Oct 2008 18:45:10 -0700	[thread overview]
Message-ID: <48FFD726.2010600@kernel.org> (raw)
In-Reply-To: <20081012071157.GA20056@colo.lackof.org>

Grant prefer to add it /sys instead of showing in bootlog

so could catch if the driver set the correct dma_mask.

Signed-off-by: Yinghai Lu <yinghai@kernel.org>

---
 drivers/pci/pci-sysfs.c |   17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Index: linux-2.6/drivers/pci/pci-sysfs.c
===================================================================
--- linux-2.6.orig/drivers/pci/pci-sysfs.c
+++ linux-2.6/drivers/pci/pci-sysfs.c
@@ -169,6 +169,21 @@ numa_node_show(struct device *dev, struc
 #endif
 
 static ssize_t
+dma_mask_bits_show(struct device *dev, struct device_attribute *attr, char *buf)
+{
+	struct pci_dev *pdev = to_pci_dev(dev);
+
+	return sprintf (buf, "%d\n", fls64(pdev->dma_mask));
+}
+
+static ssize_t
+consistent_dma_mask_bits_show(struct device *dev, struct device_attribute *attr,
+				 char *buf)
+{
+	return sprintf (buf, "%d\n", fls64(dev->coherent_dma_mask));
+}
+
+static ssize_t
 msi_bus_show(struct device *dev, struct device_attribute *attr, char *buf)
 {
 	struct pci_dev *pdev = to_pci_dev(dev);
@@ -223,6 +238,8 @@ struct device_attribute pci_dev_attrs[]
 #ifdef CONFIG_NUMA
 	__ATTR_RO(numa_node),
 #endif
+	__ATTR_RO(dma_mask_bits),
+	__ATTR_RO(consistent_dma_mask_bits),
 	__ATTR(enable, 0600, is_enabled_show, is_enabled_store),
 	__ATTR(broken_parity_status,(S_IRUGO|S_IWUSR),
 		broken_parity_status_show,broken_parity_status_store),


  reply	other threads:[~2008-10-23  1:47 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-08 23:02 [PATCH] pci: print out DMA mask info Yinghai Lu
2008-10-09 21:18 ` Grant Grundler
2008-10-09 21:27   ` Yinghai Lu
2008-10-09 21:35     ` Matthew Wilcox
2008-10-09 21:51       ` Yinghai Lu
2008-10-09 22:55         ` Grant Grundler
2008-10-09 23:05           ` Yinghai Lu
2008-10-10  2:40             ` FUJITA Tomonori
2008-10-10  4:56               ` Yinghai Lu
2008-10-10  6:08                 ` FUJITA Tomonori
2008-10-10  6:32                   ` Yinghai Lu
2008-10-10  7:32                     ` FUJITA Tomonori
2008-10-12  7:16                       ` Grant Grundler
2008-10-10 22:45               ` Grant Grundler
2008-10-14  6:50                 ` FUJITA Tomonori
2008-10-12  7:11             ` Grant Grundler
2008-10-23  1:45               ` Yinghai Lu [this message]
2008-10-23  3:28                 ` [PATCH] pci: show dma_mask bits in /sys Matthew Wilcox
2008-10-23  4:19                   ` Yinghai Lu
2008-10-23  6:44                   ` Grant Grundler
2008-10-23  8:38                     ` Rolf Eike Beer
2008-10-23 15:39                     ` Greg KH
2008-10-23 18:37                       ` H. Peter Anvin
2008-10-23 19:36                       ` Grant Grundler
2008-10-23 19:49                         ` Greg KH
2008-10-24 10:50                     ` Andi Kleen
2008-11-01 17:10                       ` Grant Grundler
2008-10-23  6:48                 ` Grant Grundler
2008-10-23  6:51                   ` Yinghai Lu
2008-10-23 19:28                     ` Grant Grundler
2008-10-10  2:40     ` [PATCH] pci: print out DMA mask info FUJITA Tomonori
2008-10-10  2:59       ` FUJITA Tomonori
2008-10-10  2:40   ` FUJITA Tomonori
2008-10-10 15:48     ` Jesse Barnes
2008-10-10 16:19       ` Yinghai Lu
2008-10-10 16:28         ` Jesse Barnes
2008-10-10 16:33         ` Matthew Wilcox
2008-10-10 16:46           ` Yinghai Lu
2008-10-10 17:12             ` Matthew Wilcox
2008-10-10 17:18               ` Roland Dreier
2008-10-12  7:38                 ` Grant Grundler
2008-10-12  7:20       ` Grant Grundler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48FFD726.2010600@kernel.org \
    --to=yinghai@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=grundler@parisc-linux.org \
    --cc=hpa@zytor.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.